Skip to content

Conversation

@sean-mcmanus
Copy link
Contributor

@sean-mcmanus sean-mcmanus commented Nov 12, 2025

It was generated by Copilot but it took multiple tries to get correct.

@sean-mcmanus sean-mcmanus requested a review from a team as a code owner November 12, 2025 22:26
@github-project-automation github-project-automation bot moved this to Pull Request in cpptools Nov 12, 2025
@bobbrow
Copy link
Member

bobbrow commented Nov 12, 2025

Isn't there a retry property we can use? I thought we used that in our other pipelines.

@sean-mcmanus
Copy link
Contributor Author

Isn't there a retry property we can use? I thought we used that in our other pipelines.

Copilot is saying

The retryCountOnTaskFailure property is available for some tasks, but not for bash or script steps.

@sean-mcmanus
Copy link
Contributor Author

sean-mcmanus commented Nov 12, 2025

Isn't there a retry property we can use? I thought we used that in our other pipelines.

Copilot is saying

The retryCountOnTaskFailure property is available for some tasks, but not for bash or script steps.

Oh, but I see it used in our other scripts? Maybe Copilot is wrong? Or could our existing scripts just be ignoring that retry?

UPDATE: I believe Copilot may have used the script because that allows a timed sleep between retries which the retryCountOnTaskFaiure doesn't do...however, I don't know if this failure case requires a sleep or not.

UPDATE: Next time when Copilot generates unexpected code, I should ask it why instead of just changing it since it might have a reason such as this case. I hit that issue before in another case too.

bobbrow
bobbrow previously approved these changes Nov 12, 2025
@sean-mcmanus
Copy link
Contributor Author

sean-mcmanus commented Nov 13, 2025

@bobbrow I switched by back to the script to allow a sleep between retries since otherwise I suspect it will just fail repeatedly like we hit in another case where we had to use a similar loop with a sleep.

UPDATE: Okay, I finally got it to work using retry on the task and a sleep in the script -- I hit a problem with the \ not working from the variable expansion in the bash script that I had to add a couple lines to fix.

@sean-mcmanus sean-mcmanus requested a review from bobbrow November 13, 2025 00:51
@sean-mcmanus sean-mcmanus merged commit cf5de9c into main Nov 13, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from Pull Request to Done in cpptools Nov 13, 2025
@sean-mcmanus sean-mcmanus deleted the seanmcm/addBuildFilesRetry branch November 13, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants