Added multiple element preview on hover of scss selector#308
Open
GauravB159 wants to merge 3 commits intomicrosoft:mainfrom
Open
Added multiple element preview on hover of scss selector#308GauravB159 wants to merge 3 commits intomicrosoft:mainfrom
GauravB159 wants to merge 3 commits intomicrosoft:mainfrom
Conversation
Contributor
Author
Collaborator
|
Yes, I agree that this can get very complicated. The hover size should not get too long. Maybe write (1 more) behind |
Contributor
Author
|
Hmm, I'm not sure how to limit the depth. Possibly depends on what the most frequent use case for this would be. I don't think people would want to preview a really deep node list anyways. I'm not sure what you mean by write one more behind Basically, the way it currently works is, if the second to last nested selector has multiple values, it picks up those, but other than that it picks the first selector in each ancestor. Basically a depth of 1, I guess. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Partial fix for #249
Still need to figure out the logic for specificity. There seems to be some kind of bug in the production build itself.
Still need to add tests for the new feature.