Skip to content

Updating dependencies #3599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vidorteg wants to merge 12 commits into from
Closed

Updating dependencies #3599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ab6031d
Upgrading dependencies
vidorteg Oct 8, 2025
726a1f7
changing from LF to CLRF
vidorteg Oct 8, 2025
6838881
Addressing feedback
vidorteg Oct 8, 2025
7ad1fc8
rverting changes
vidorteg Oct 8, 2025
7c4e7b8
Adding changes again
vidorteg Oct 8, 2025
d54eb54
Reverting unintended format changes
vidorteg Oct 8, 2025
dc50004
redoing changes
vidorteg Oct 8, 2025
90dd143
Removing unintended format changes
vidorteg Oct 8, 2025
51680f5
Removing unintended change
vidorteg Oct 8, 2025
6e0ad36
Remove Unintended
vidorteg Oct 8, 2025
4c5d6a0
Removing unintended
vidorteg Oct 8, 2025
97465c1
Redoing change
vidorteg Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .eslintignore
View file
Open in desktop

This file was deleted.

275 changes: 131 additions & 144 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,148 +1,135 @@
// Generated using recommended approach
// https://code.visualstudio.com/api/advanced-topics/tslint-eslint-migration
module.exports = {
"env": {
"browser": true,
"es6": true,
"node": true
},
"extends": [
"plugin:@typescript-eslint/recommended",
"plugin:@typescript-eslint/recommended-requiring-type-checking"
import js from '@eslint/js';
import typescript from '@typescript-eslint/eslint-plugin';
import typescriptParser from '@typescript-eslint/parser';
import jsdoc from 'eslint-plugin-jsdoc';
import preferArrow from 'eslint-plugin-prefer-arrow';
import importPlugin from 'eslint-plugin-import';
import globals from 'globals';

export default [
js.configs.recommended,
{
files: ['**/*.{js,ts,tsx}'],
ignores: [
'**/*.test*',
'**/test/**/*'
],
"parser": "@typescript-eslint/parser",
"parserOptions": {
"project": "tsconfig.json",
"sourceType": "module"
languageOptions: {
parser: typescriptParser,
parserOptions: {
project: 'tsconfig.json',
sourceType: 'module'
},
globals: {
...globals.browser,
...globals.node,
...globals.es2022,
}
},
"plugins": [
"eslint-plugin-jsdoc",
"eslint-plugin-prefer-arrow",
"@typescript-eslint",
"import",
],
/**
* ESLint rules
*
* All available rules: http://eslint.org/docs/rules/
*
* Rules take the following form:
* 'rule-name', [severity, { opts }]
* Severity: 2 == error, 1 == warning, 0 == off.
*/
'rules': {
/**
* Enforced rules
*/


// syntax preferences
'quotes': [2, 'single', {'avoidEscape': true, 'allowTemplateLiterals': true}],
'semi': 2,
'no-extra-semi': 2,
'comma-style': [2, 'last'],
'wrap-iife': [2, 'inside'],
'spaced-comment': [2, 'always', {'markers': ['*']}],
'eqeqeq': [2],
'accessor-pairs': [2, {'getWithoutSet': false, 'setWithoutGet': false}],
'curly': 2,
'new-parens': 2,
'func-call-spacing': 2,
'arrow-parens': [2, 'as-needed'],
'eol-last': 2,

// anti-patterns
'no-caller': 2,
// MSFT: Not supported by esprima which is used by localization scripts.
//no-case-declarations': 2,
'no-cond-assign': 2,
'no-console': [2, {'allow': ['assert', 'context', 'error', 'timeStamp', 'time', 'timeEnd', 'warn']}],
'no-debugger': 2,
'no-dupe-keys': 2,
'no-duplicate-case': 2,
'no-else-return': [2, {'allowElseIf': false}],
'no-empty-character-class': 2,
'no-global-assign': 2,
'no-implied-eval': 2,
'no-labels': 2,
'no-multi-str': 2,
'no-new-object': 2,
'no-octal-escape': 2,
'no-self-compare': 2,
'no-shadow-restricted-names': 2,
'no-unreachable': 2,
'no-unsafe-negation': 2,
'no-unused-vars': [2, {'args': 'none', 'vars': 'local'}],
'no-var': 2,
'no-with': 2,
'prefer-const': 2,
'radix': 2,
'valid-typeof': 2,
'no-return-assign': [2, 'always'],

// es2015 features
'require-yield': 2,
'template-curly-spacing': [2, 'never'],

// spacing details
'space-infix-ops': 2,
'space-in-parens': [2, 'never'],
'space-before-function-paren': [2, {'anonymous': 'never', 'named': 'never', 'asyncArrow': 'always'}],
'no-whitespace-before-property': 2,
'keyword-spacing': [
2, {
'overrides': {
'if': {'after': true},
'else': {'after': true},
'for': {'after': true},
'while': {'after': true},
'do': {'after': true},
'switch': {'after': true},
'return': {'after': true}
}
plugins: {
'@typescript-eslint': typescript,
'jsdoc': jsdoc,
'prefer-arrow': preferArrow,
'import': importPlugin
},
rules: {
// Apply TypeScript recommended rules manually
...typescript.configs.recommended.rules,
...typescript.configs['recommended-requiring-type-checking'].rules,

// Let TypeScript handle undefined variables
'no-undef': 'off',

// syntax preferences
'quotes': ['error', 'single', {'avoidEscape': true, 'allowTemplateLiterals': true}],
'semi': 'error',
'no-extra-semi': 'error',
'comma-style': ['error', 'last'],
'wrap-iife': ['error', 'inside'],
'spaced-comment': ['error', 'always', {'markers': ['*']}],
'eqeqeq': ['error'],
'accessor-pairs': ['error', {'getWithoutSet': false, 'setWithoutGet': false}],
'curly': 'error',
'new-parens': 'error',
'func-call-spacing': 'error',
'arrow-parens': ['error', 'as-needed'],
'eol-last': 'error',

// anti-patterns
'no-caller': 'error',
'no-cond-assign': 'error',
'no-console': ['error', {'allow': ['assert', 'context', 'error', 'timeStamp', 'time', 'timeEnd', 'warn']}],
'no-debugger': 'error',
'no-dupe-keys': 'error',
'no-duplicate-case': 'error',
'no-else-return': ['error', {'allowElseIf': false}],
'no-empty-character-class': 'error',
'no-global-assign': 'error',
'no-implied-eval': 'error',
'no-labels': 'error',
'no-multi-str': 'error',
'no-new-object': 'error',
'no-octal-escape': 'error',
'no-self-compare': 'error',
'no-shadow-restricted-names': 'error',
'no-unreachable': 'error',
'no-unsafe-negation': 'error',
'no-var': 'error',
'no-with': 'error',
'prefer-const': 'error',
'radix': 'error',
'valid-typeof': 'error',
'no-return-assign': ['error', 'always'],

// es2015 features
'require-yield': 'error',
'template-curly-spacing': ['error', 'never'],

// spacing details
'space-infix-ops': 'error',
'space-in-parens': ['error', 'never'],
'space-before-function-paren': ['error', {'anonymous': 'never', 'named': 'never', 'asyncArrow': 'always'}],
'no-whitespace-before-property': 'error',
'keyword-spacing': [
'error', {
'overrides': {
'if': {'after': true},
'else': {'after': true},
'for': {'after': true},
'while': {'after': true},
'do': {'after': true},
'switch': {'after': true},
'return': {'after': true}
}
],
'arrow-spacing': [2, {'after': true, 'before': true}],

// file whitespace
'no-multiple-empty-lines': [2, {'max': 2}],
'no-mixed-spaces-and-tabs': 2,
'no-trailing-spaces': 2,
'linebreak-style': [2, process.platform === 'win32' ? 'windows' : 'unix'],

/**
* Disabled, aspirational rules
*/


'indent': [0, 2, {'SwitchCase': 1, 'CallExpression': {'arguments': 2}, 'MemberExpression': 2}],

// brace-style is disabled, as eslint cannot enforce 1tbs as default, but allman for functions
'brace-style': [0, 'allman', {'allowSingleLine': true}],

// key-spacing is disabled, as some objects use value-aligned spacing, some not.
'key-spacing': [0, {'beforeColon': false, 'afterColon': true, 'align': 'value'}],
// quote-props is diabled, as property quoting styles are too varied to enforce.
'quote-props': [0, 'as-needed'],

// no-implicit-globals will prevent accidental globals
'no-implicit-globals': [0],

'@typescript-eslint/explicit-member-accessibility': [0],
'@typescript-eslint/no-explicit-any': 2,
'@typescript-eslint/restrict-template-expressions': 0,

// Closure does not properly typecheck default exports
'import/no-default-export': 2,
},
'overrides': [{
'files': ['*.ts'],
'rules': {
'@typescript-eslint/explicit-member-accessibility': [2, {'accessibility': 'no-public'}],
'comma-dangle': [2, 'always-multiline'],
// run just the TypeScript unused-vars rule, else we get duplicate errors
'no-unused-vars': 0,
'@typescript-eslint/no-unused-vars': [2, {'argsIgnorePattern': '^_'}],
}
}]
};
],
'arrow-spacing': ['error', {'after': true, 'before': true}],

// file whitespace
'no-multiple-empty-lines': ['error', {'max': 2}],
'no-mixed-spaces-and-tabs': 'error',
'no-trailing-spaces': 'error',
'linebreak-style': ['error', process.platform === 'win32' ? 'windows' : 'unix'],

// Disabled rules
'indent': 'off',
'brace-style': 'off',
'key-spacing': 'off',
'quote-props': 'off',
'no-implicit-globals': 'off',

// TypeScript rules (overrides to the recommended configs)
'@typescript-eslint/explicit-member-accessibility': 'off',
'@typescript-eslint/no-explicit-any': 'error',
'@typescript-eslint/restrict-template-expressions': 'off',
'@typescript-eslint/no-unsafe-call': 'off',

// skiping variables that start with underscore
'no-unused-vars': 'off', // Turn off for TypeScript files
'@typescript-eslint/no-unused-vars': ['error', {'argsIgnorePattern': '^_', 'varsIgnorePattern': '^_'}],

// Import rules
'import/no-default-export': 'error'
}
}
];
Loading
Loading