QuickInput : Add an example of prompt with history#89
Open
AdrieanKhisbe wants to merge 9 commits intomicrosoft:mainfrom
Open
QuickInput : Add an example of prompt with history#89AdrieanKhisbe wants to merge 9 commits intomicrosoft:mainfrom
AdrieanKhisbe wants to merge 9 commits intomicrosoft:mainfrom
Conversation
e26209d to
c4978ea
Compare
chrmarti
reviewed
Sep 4, 2018
chrmarti
reviewed
Sep 4, 2018
chrmarti
reviewed
Sep 4, 2018
chrmarti
reviewed
Sep 4, 2018
Author
|
Thanks for your feedback @chrmarti. :) |
bfbd137 to
136dc25
Compare
Author
|
Hey @chrmarti, |
Author
|
@chrmarti I see there is a conflict, I can rebase to solve it if you ask me to. :) |
136dc25 to
9bb3238
Compare
Author
|
Hello @chrmarti, gentle reminder after solving the conflict :) |
chrmarti
requested changes
Dec 11, 2019
Contributor
|
@AdrieanKhisbe Thanks for the update. I have added a few comments. (Sorry for the delay.) |
Author
Thanks for the review @chrmarti! I just took into account your feedback, tell me if I misunderstood something. |
chrmarti
reviewed
Dec 16, 2019
Author
|
@chrmarti and here it is :) |
This was referenced Apr 26, 2022
Open
Open
This was referenced Apr 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started to prototype a prompt with history, in order to improve prompting of command in VscodeVim.
Here is what I came up with.
I opened a PR to receive feedback and maybe if you wish incorporate it in the Quick Input sample
It is based on a QuickPick and record commands to a dedicated file.
Improvement could be made (max number of item notably), but this is a working MVP.
Thanks in advance for your feedbacks