Skip to content

Fix typo ; Update configMigration.ts #15719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix typo ; Update configMigration.ts #15719

wants to merge 1 commit into from

Conversation

furkan7258
Copy link

Fixes #

  • Ignore Proposed API verification.

@DonJayamanne DonJayamanne requested a review from amunger May 28, 2024 20:55
amunger
amunger requested changes May 28, 2024
View reviewed changes
Copy link
Contributor

@amunger amunger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the actual config ID has the typo, so only fixing it here will not help.
Also, just fixing the config ID would break the configuration for everyone that has it set - migrating would be necessary, which is a lot of work to fix a typo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amunger amunger amunger requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@amunger amunger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@furkan7258 @amunger