Skip to content

Conversation

suprjinx
Copy link

Fixes #3998

@suprjinx
Copy link
Author

@microsoft-github-policy-service agree company="G-Research OSS"

@suprjinx suprjinx force-pushed the reconnect-kernels branch from 1d32d5f to 9bcb1b1 Compare August 5, 2025 17:52
@DonJayamanne
Copy link
Contributor

@suprjinx thank you for submitting this PR.
Wanted to leave a comment on this before you spend more time on this.
Unfortunately we will not be able to take this PR, as this relies on spinning up Jupyter server locally.
Not everyone will have Jupyter lab/notebook installed. let alone Python.
The Jupyter extension works with Kernels such as R, Julia and the like even without installing Python/Jupyter.

Enforcing such a limitation wouldn't work for all
Besides you can already spin up a Jupyter application externally and connect to that using Jupyter extension and the connections are never lose. I.e. even after you shutdown VS Code and restart it, it will re-connect to the same server/kernels.

Again, thank you for submitting this PR and attempting to fix this, however I cannot take this due to above mentioned issues.

@suprjinx
Copy link
Author

suprjinx commented Aug 19, 2025

@DonJayamanne thanks for the feedback -- what do you think of simpler implementation that just offers an option to start server in the kernel connection chooser eg:

image

The idea would be a Launch Persistent Server command that runs jupyter server, and we then connect using the Existing Server pathway. Implemented here: #16915

Re: users who don't have Jupyter installed -- perhaps we could disable this option when there are no python environments available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Persistent Jupyter Kernels - Restore/Re-connect to an existing local/remote kernel (do not shutdown kernel upon closing/reloading vscode/vscode.dev)
2 participants