fix: first try widget downloads with custom fetch #17098
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially, I set out to fix a logging bug; if the HTTP attempt (no custom fetch) failed but the custom fetch succeeded, the HTTP error would still be logged. After making that fix, I came to the opinion that it likely makes more sense to first try the custom fetch and then fallback. Otherwise we're issuing a ton of redundant requests.
This change also:
getWidgetScriptSource*methods to an abstracteddownloadFilefunction.ex. This duplicated the context (httpclient vs. fetch). Since the inner error contains this info, we can use the same top level error message when we log.With minimal context of the existing code, I can't easily determine... but for reviewers with more background:
I looked to write or modify a unit test, but the
RemoteIPyWidgetScriptManagerdoesn't appear to have existing coverage. If reviewers feel the change necessitates a test, I can look to cover the component. Though IMO that's out of scope given the precedent.