Skip to content

Conversation

MariaSolOs
Copy link
Contributor

@MariaSolOs MariaSolOs commented May 2, 2025

Closes microsoft/language-server-protocol#2133

Complements microsoft/language-server-protocol#2134 which contains the respective updates to the specification.

@MariaSolOs MariaSolOs force-pushed the did-change-workspace-folders branch from 2e4dde6 to 87aa6ea Compare May 3, 2025 20:36
@MariaSolOs MariaSolOs changed the title Add client capability to workspace/didChangeWorkspaceFolders notification Add WorkspaceFoldersClientCapabilites May 3, 2025
@MariaSolOs MariaSolOs force-pushed the did-change-workspace-folders branch from 87aa6ea to e90ae92 Compare May 3, 2025 21:11
@dbaeumer
Copy link
Member

dbaeumer commented May 5, 2025

@MariaSolOs can you explain why you think this is necessary. The assumption was always that if a client has support for workspace folders it also supports change notifications. If we add the client capability it might break existing servers since they instead of a boolean receive a object literal.

@dbaeumer dbaeumer added the info-needed Issue requires more information from poster label May 5, 2025
@MariaSolOs
Copy link
Contributor Author

@MariaSolOs can you explain why you think this is necessary. The assumption was always that if a client has support for workspace folders it also supports change notifications. If we add the client capability it might break existing servers since they instead of a boolean receive a object literal.

My main motivation here is being able to announce client support for dynamically registering to receive workspace/didChangeWorkspaceFolders notifications. This aligns with the client capabilities of other requests (e.g. CodeLensClientCapabilities).

@dbaeumer
Copy link
Member

dbaeumer commented May 7, 2025

I think we should still be able to allow for registering without breaking servers. We could offer a different route for this if it is necessary.

@MariaSolOs
Copy link
Contributor Author

I think we should still be able to allow for registering without breaking servers. We could offer a different route for this if it is necessary.

Fair enough. I'm open to suggestions on how to include the necessary dynamicRegistration support information in a backwards compatible way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

workspace.workspaceFolders client capability missing dynamic registration support
2 participants