Skip to content

Add "mark as viewed/unviewed" in multi-diff editor #5986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add "mark as viewed/unviewed" in multi-diff editor #5986

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
"contribCommentThreadAdditionalMenu",
"contribCommentsViewThreadMenus",
"contribEditorContentMenu",
"contribMultiDiffEditorMenus",
"contribShareMenu",
"diffCommand",
"fileComments",
Expand Down Expand Up @@ -2389,6 +2390,18 @@
"when": "(resourceScheme == pr) || (resourcePath in github:viewedFiles) || (resourcePath in github:unviewedFiles)"
}
],
"multiDiffEditor/resource/title": [
{
"command": "pr.markFileAsViewed",
"group": "navigation",
"when": "resourceScheme != pr && resourceScheme != review && resourceScheme != filechange && resourcePath in github:unviewedFiles"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resourcePath isn't set here. This is an upstream issue that we need to wait for a fix for

},
{
"command": "pr.unmarkFileAsViewed",
"group": "navigation",
"when": "resourceScheme != pr && resourceScheme != review && resourceScheme != filechange && resourcePath in github:viewedFiles"
}
],
"editor/content": [
{
"command": "pr.acceptMerge",
Expand Down