Skip to content

Conversation

joshspicer
Copy link
Member

@joshspicer joshspicer commented Oct 9, 2025

fix for #7954 being far too verbose.

@connor4312
Copy link
Member

connor4312 commented Oct 9, 2025

I suggest adding * (with surrounding spaces_ for JS/TS docblock comments too, and /// for Rust and C# docblock styles

@joshspicer
Copy link
Member Author

nice

image

@joshspicer joshspicer mentioned this pull request Oct 9, 2025
@joshspicer joshspicer marked this pull request as ready for review October 9, 2025 22:00
@vs-code-engineering vs-code-engineering bot added this to the October 2025 milestone Oct 9, 2025
@joshspicer joshspicer enabled auto-merge (squash) October 9, 2025 22:16
Comment on lines +625 to +630
"default": [
"//",
"#",
"--",
" * ",
"///"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems suspicious. It's something that would be language specific too.

<!-- TODO: ...... -->
/*
TODO: some multi-line
comment with context
*/
<#
TODO: PowerShell block comments are weird
I know
#>

https://github.com/microsoft/vscode/blob/55f06131905f07dde60f301aa56be6e2f52155a3/extensions/make/language-configuration.json#L2-L7

The comment syntax is declared by the language support, I feel like we should somehow leverage that if we can.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/microsoft/vscode/blob/55f06131905f07dde60f301aa56be6e2f52155a3/src/vs/editor/common/languages/languageConfigurationRegistry.ts#L35-L47

we have this in core... and we have a number of commands in core that are about retrieval of symbols:
https://code.visualstudio.com/api/references/commands#commands

I wonder if this warrants some way to get the LanguageConfiguration via a Command. Or at least just the comment stuff...

@hediet @alexdima I see your name around this code, maybe you have ideas

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pointers, this looks a lot more correct.

I justified that this was ok since it's configurable via a setting and did not know we could possibly leverage core for this information.

Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should have two setting that both control whether the code action/codelens show.

Can we instead just remove "BUG" from the list of defaults?

@joshspicer
Copy link
Member Author

@alexr00 I still think it's incorrect to match outside of a comment. Do you disagree?

@TylerLeonhardt thanks for the idea/pointers

@joshspicer joshspicer marked this pull request as draft October 10, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants