-
Notifications
You must be signed in to change notification settings - Fork 670
Support emoji completions in review comments #8009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Updated so it will only trigger if the leading |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The emoji picker doesn't reset now, but it does close. I think what I expected is that it still shows, just doesn't reset. I actually don't know if this is possible though since the second :
is the trigger character.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, might be nice if a direct invoke ( CompletionTriggerKind
.Invoke`, rather than trigger character) would show the completions even if not preceeded by whitespace.
Closes #7178