Skip to content

Conversation

kycutler
Copy link
Contributor

4e3fee72-6676-4976-ab94-5c4bb19161e3

Closes #7178

Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small changes, plus one thing that doesn't work they way I'd expect: If I type a full emoji expression (ex. :running:, I don't expect the picker to reset.

Image

@kycutler
Copy link
Contributor Author

A few small changes, plus one thing that doesn't work they way I'd expect: If I type a full emoji expression (ex. :running:, I don't expect the picker to reset.

Good catch! Updated so it will only trigger if the leading : appears after whitespace or beginning of line.

@kycutler kycutler requested a review from alexr00 October 16, 2025 15:29
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The emoji picker doesn't reset now, but it does close. I think what I expected is that it still shows, just doesn't reset. I actually don't know if this is possible though since the second : is the trigger character.

Looks good!

Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, might be nice if a direct invoke ( CompletionTriggerKind.Invoke`, rather than trigger character) would show the completions even if not preceeded by whitespace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add emoji completions for :smile: style emoji

2 participants