Update files to match new Prettier settings (#15030)

Author: brettcannon

.eslintrc

@@ -11,7 +11,8 @@
         "plugin:@typescript-eslint/recommended",
         "plugin:import/errors",
         "plugin:import/warnings",
-        "plugin:import/typescript"
+        "plugin:import/typescript",
+        "prettier"
     ],
     "rules": {
         // Overriding ESLint rules with Typescript-specific ones
@@ -40,14 +41,7 @@
         "no-useless-constructor": "off",
         "@typescript-eslint/no-useless-constructor": "error",
         "@typescript-eslint/no-var-requires": "off",
-        // Overriding formatting rules to let Prettier handle them
-        "comma-dangle": "off",
-        "function-paren-newline": "off",
-        "implicit-arrow-linebreak": "off",
-        "indent": "off",
-        "max-len": "off",
-        "object-curly-newline": ["error", {"ImportDeclaration": {"consistent": true}}],
-        "operator-linebreak": "off",
+
         // Other rules
         "class-methods-use-this": ["error", {"exceptMethods": ["dispose"]}],
         "func-names": "off",
@@ -63,12 +57,6 @@
         "import/prefer-default-export": "off",
         "linebreak-style": "off",
         "no-await-in-loop": "off",
-        "no-confusing-arrow": [
-            "error",
-            {
-                "allowParens": true
-            }
-        ],
         "no-console": "off",
         "no-control-regex": "off",
         "no-extend-native": "off",

.prettierignore

@@ -3,7 +3,7 @@ module.exports = {
     printWidth: 120,
     tabWidth: 4,
     endOfLine: 'auto',
-    trailingComma: 'none',
+    trailingComma: 'all',
     overrides: [
         {
             files: ['*.yml', '*.yaml'],

.prettierrc.js

@@ -24,7 +24,7 @@ exports.nodeModulesToExternalize = [
     'diff-match-patch',
     'sudo-prompt',
     'node-stream-zip',
-    'xml2js'
+    'xml2js',
 ];
 exports.nodeModulesToReplacePaths = [...exports.nodeModulesToExternalize];
 function getDefaultPlugins(name) {
@@ -37,8 +37,8 @@ function getDefaultPlugins(name) {
                 reportFilename: `${name}.analyzer.html`,
                 generateStatsFile: true,
                 statsFilename: `${name}.stats.json`,
-                openAnalyzer: false // Open file manually if you want to see it :)
-            })
+                openAnalyzer: false, // Open file manually if you want to see it :)
+            }),
         );
     }
     return plugins;

build/webpack/common.js

@@ -36,7 +36,7 @@ class Base64Visitor {
             'data-uri',
             [new Base64MimeTypeNode(), URLNode.value],
             URLNode.index || 0,
-            URLNode.currentFileInfo
+            URLNode.currentFileInfo,
         );
     }
 }

build/webpack/plugins/less-plugin-base64.js

@@ -15,40 +15,40 @@ const config = {
     mode: 'production',
     target: 'node',
     entry: {
-        extension: './src/client/extension.ts'
+        extension: './src/client/extension.ts',
     },
     devtool: 'source-map',
     node: {
-        __dirname: false
+        __dirname: false,
     },
     module: {
         rules: [
             {
                 test: /\.ts$/,
                 use: [
                     {
-                        loader: path.join(__dirname, 'loaders', 'externalizeDependencies.js')
-                    }
-                ]
+                        loader: path.join(__dirname, 'loaders', 'externalizeDependencies.js'),
+                    },
+                ],
             },
             {
                 test: /\.ts$/,
                 exclude: /node_modules/,
                 use: [
                     {
-                        loader: 'ts-loader'
-                    }
-                ]
+                        loader: 'ts-loader',
+                    },
+                ],
             },
             {
                 test: /\.node$/,
                 use: [
                     {
-                        loader: 'node-loader'
-                    }
-                ]
-            }
-        ]
+                        loader: 'node-loader',
+                    },
+                ],
+            },
+        ],
     },
     externals: ['vscode', 'commonjs', ...existingModulesInOutDir],
     plugins: [...common.getDefaultPlugins('extension')],
@@ -57,17 +57,17 @@ const config = {
             // Pointing pdfkit to a dummy js file so webpack doesn't fall over.
             // Since pdfkit has been externalized (it gets updated with the valid code by copying the pdfkit files
             // into the right destination).
-            pdfkit: path.resolve(__dirname, 'pdfkit.js')
+            pdfkit: path.resolve(__dirname, 'pdfkit.js'),
         },
         extensions: ['.ts', '.js'],
-        plugins: [new tsconfig_paths_webpack_plugin.TsconfigPathsPlugin({ configFile: configFileName })]
+        plugins: [new tsconfig_paths_webpack_plugin.TsconfigPathsPlugin({ configFile: configFileName })],
     },
     output: {
         filename: '[name].js',
         path: path.resolve(constants.ExtensionRootDir, 'out', 'client'),
         libraryTarget: 'commonjs2',
-        devtoolModuleFilenameTemplate: '../../[resource-path]'
-    }
+        devtoolModuleFilenameTemplate: '../../[resource-path]',
+    },
 };
 // tslint:disable-next-line:no-default-export
 exports.default = config;

build/webpack/webpack.extension.config.js

@@ -18,25 +18,25 @@ const config = {
     entry: entryItems,
     devtool: 'source-map',
     node: {
-        __dirname: false
+        __dirname: false,
     },
     module: {},
     externals: ['vscode', 'commonjs'],
     plugins: [
         ...common.getDefaultPlugins('dependencies'),
         // vsls requires our package.json to be next to node_modules. It's how they
         // 'find' the calling extension.
-        new copyWebpackPlugin([{ from: './package.json', to: '.' }])
+        new copyWebpackPlugin([{ from: './package.json', to: '.' }]),
     ],
     resolve: {
-        extensions: ['.js']
+        extensions: ['.js'],
     },
     output: {
         filename: '[name].js',
         path: path.resolve(constants.ExtensionRootDir, 'out', 'client'),
         libraryTarget: 'commonjs2',
-        devtoolModuleFilenameTemplate: '../../[resource-path]'
-    }
+        devtoolModuleFilenameTemplate: '../../[resource-path]',
+    },
 };
 // tslint:disable-next-line:no-default-export
 exports.default = config;