Skip to content

add uri for unittest subtests fix "go to test" bug #24544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 4, 2024
Merged

add uri for unittest subtests fix "go to test" bug #24544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83a53e3
add uri for unittest subtests fix "go to test" bug
eleanorjboyd Dec 4, 2024
b3f9912
add check in test for subtest URI
eleanorjboyd Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/client/testing/testController/common/resultResolver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,11 @@ export class PythonResultResolver implements ITestResultResolver {
// clear since subtest items don't persist between runs
clearAllChildren(parentTestItem);
}
const subTestItem = this.testController?.createTestItem(subtestId, subtestId);
const subTestItem = this.testController?.createTestItem(
subtestId,
subtestId,
parentTestItem.uri,
);
// create a new test item for the subtest
if (subTestItem) {
const traceback = data.traceback ?? '';
Expand Down Expand Up @@ -293,7 +297,11 @@ export class PythonResultResolver implements ITestResultResolver {
// clear since subtest items don't persist between runs
clearAllChildren(parentTestItem);
}
const subTestItem = this.testController?.createTestItem(subtestId, subtestId);
const subTestItem = this.testController?.createTestItem(
subtestId,
subtestId,
parentTestItem.uri,
);
// create a new test item for the subtest
if (subTestItem) {
parentTestItem.children.add(subTestItem);
Expand Down
5 changes: 4 additions & 1 deletion src/test/testing/testController/resultResolver.unit.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,10 +344,12 @@ suite('Result Resolver tests', () => {
resultResolver.runIdToTestItem.set(subtestName, mockSubtestItem);

let generatedId: string | undefined;
let generatedUri: Uri | undefined;
testControllerMock
.setup((t) => t.createTestItem(typemoq.It.isAny(), typemoq.It.isAny()))
.setup((t) => t.createTestItem(typemoq.It.isAny(), typemoq.It.isAny(), typemoq.It.isAny()))
.callback((id: string) => {
generatedId = id;
generatedUri = workspaceUri;
traceLog('createTestItem function called with id:', id);
})
.returns(() => ({ id: 'id_this', label: 'label_this', uri: workspaceUri } as TestItem));
Expand All @@ -373,6 +375,7 @@ suite('Result Resolver tests', () => {

// verify that the passed function was called for the single test item
assert.ok(generatedId);
assert.strictEqual(generatedUri, workspaceUri);
assert.strictEqual(generatedId, '[subTest with spaces and [brackets]]');
});
test('resolveExecution handles failed tests correctly', async () => {
Expand Down
Loading