Fix) Prevent keyboard interrupt for Python3.13 REPL non-Windows #24555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonykim1
added
bug
justschen
approved these changes
Dec 9, 2024
karthiknadig
reviewed
Dec 9, 2024
| const pythonrcSetting = config.get<boolean>('terminal.shellIntegration.enabled'); | ||
| if ((isPythonShell && !pythonrcSetting) || (isPythonShell && isWindows())) { | ||
|
|
||
| let isPython313 = false; |
Member
There was a problem hiding this comment.
There is a bug here isPython313 is not set in the code below.
Author
There was a problem hiding this comment.
Not sure what happened but I meant to set it here:
isPython313 = pythonVersion?.sysVersion?.startsWith('3.13');
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further resolves: #24422
Prevent keyboard interrupt for Mac and Linux when using Python3.13
Having Python3.13 as interpreter choice and then enabling shell integration where it is normally supported (we disabled temporarily for Python3.13 due to python/cpython#126131), lead to edge case.
So although we don't override user's PS1 in Python side after checking Python3.13 is selected, we were not aware of this in typescript side, leading to wrongly using executeCommand inside Python terminal REPL (Python3.13 IDLE), instead of sendText.