Use env extension when available #24564
Conversation
karthiknadig
force-pushed
the
env-ext1
branch
from
9112690 to
cc548e8
Compare
| hideFromUser: this.options?.hideFromUser, | ||
| }); | ||
| } else { | ||
| this.terminalShellType = this.terminalHelper.identifyTerminalShell(this.terminal); |
There was a problem hiding this comment.
this isn't 100% accurate in terms of always getting the shell type right, correct?
There was a problem hiding this comment.
It is not, this is the same detector as the one Python extension uses. We need the shell type API to be more accurate.
| }); | ||
| this.terminalAutoActivator.disableAutoActivation(this.terminal); | ||
|
|
||
| await sleep(100); |
There was a problem hiding this comment.
is there reason why we wait for short duration before activateEnvironmentInTerminal
There was a problem hiding this comment.
This is also from the existing activation. This is to give shell initialization enough time to start.
|
|
||
| if (pythonEnv && project) { | ||
| const fixedOptions = options ? { ...options } : { cwd: project.uri }; | ||
| const terminal = await api.createTerminal(pythonEnv, fixedOptions); |
There was a problem hiding this comment.
it seems like this is calling createTerminal from env extension API, Im trying to understand why this and the interpreter one are both called "legacy"
There was a problem hiding this comment.
Because it is temporary solution to the old features in the Python extension. These apis can be deleted when we delete the code for old Python features.
karthiknadig
added
verified
No description provided.