Discovery cancellation

[eleanorjboyd]

fixes #24602

[Copilot]

Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.

Files not reviewed (2)

• src/client/testing/testController/workspaceTestAdapter.ts: Evaluated as low risk
• src/client/testing/testController/pytest/pytestExecutionAdapter.ts: Evaluated as low risk

Comments suppressed due to low confidence (1)

src/client/testing/testController/pytest/pytestDiscoveryAdapter.ts:130

• Redundant cancellation handling. The token?.onCancellationRequested callback is defined twice, once for proc and once for resultProc. This can be simplified to avoid confusion.

token?.onCancellationRequested(() => {

Tip: Leave feedback on Copilot's review comments with the 👎 and 👍 buttons to help improve review quality. Learn more

[vs-code-engineering]

This PR originates from a fork. If the changes appear safe, you can trigger the pipeline by commenting /AzurePipelines run.

[Copilot]

Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.

Files not reviewed (3)

• src/client/testing/testController/workspaceTestAdapter.ts: Evaluated as low risk
• src/client/testing/testController/pytest/pytestExecutionAdapter.ts: Evaluated as low risk
• src/client/testing/testController/unittest/testExecutionAdapter.ts: Evaluated as low risk

Comments suppressed due to low confidence (1)

src/client/testing/testController/pytest/pytestDiscoveryAdapter.ts:194

• The assignment of resultProc should be moved before the token cancellation check to avoid any potential race conditions.

const result = execService?.execObservable(execArgs, spawnOptions);

Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more