Skip to content

Use new feedback setting #24929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2025
Merged

Use new feedback setting #24929

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ddb4a5a
Use new feedback setting
luabud Mar 26, 2025
be6fa04
Fix tests
luabud Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/client/activation/extensionSurvey.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,14 +59,14 @@ export class ExtensionSurveyPrompt implements IExtensionSingleActivationService
return false;
}

let feedbackDisabled = false;
let feedbackEnabled = false;

const telemetryConfig = this.workspace.getConfiguration('telemetry');
if (telemetryConfig) {
feedbackDisabled = telemetryConfig.get<boolean>('disableFeedback', false);
feedbackEnabled = telemetryConfig.get<boolean>('feedback.enabled', true);
}

if (feedbackDisabled) {
if (!feedbackEnabled) {
return false;
}

Expand Down
Loading