Skip to content

Conversation

@DonJayamanne
Copy link

No description provided.

}
},
{
"name": "list_python_packages",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this tool, was disabled

@DonJayamanne DonJayamanne added no-changelog No news entry required skip package*.json package.json and package-lock.json don't both need updating skip tests Updates to tests unnecessary skip-issue-check labels May 20, 2025
registerCreateEnvironmentProvider(condaCreationProvider()),
onCreateEnvironmentExited(async (e: EnvironmentDidCreateEvent) => {
if (e.path && e.options?.selectEnvironment) {
await interpreterPathService.update(
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karthiknadig Found that this is another place where user action results in updating the Python path.
Instead of injecting another dependency, I decided to use the more generic one that is responsible for all updates to python path,


async activate(_resource: Resource, _startupStopWatch?: StopWatch): Promise<void> {
this.extensionContext.subscriptions.push(
commands.registerCommand('python.getRecommendedEnvironment', async (resource: Resource) => {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creating a command, I think command is simpler as Jupyter and Python Env extension will need this API.

*/
@captureTelemetry(EventName.SELECT_INTERPRETER)
public async setInterpreter(): Promise<true | undefined> {
public async setInterpreter(options?: {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karthiknadig I added back button and actions into the interpreter quick pick

resourcePath?: string;
}

export class ListPythonPackagesTool implements LanguageModelTool<IResourceReference> {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not required

@DonJayamanne DonJayamanne marked this pull request as ready for review May 20, 2025 03:17
@vs-code-engineering vs-code-engineering bot added this to the May 2025 milestone May 20, 2025
@DonJayamanne DonJayamanne merged commit 4a602e8 into main May 20, 2025
85 checks passed
anthonykim1 pushed a commit to anthonykim1/vscode-python that referenced this pull request Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No news entry required skip package*.json package.json and package-lock.json don't both need updating skip tests Updates to tests unnecessary skip-issue-check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants