Skip to content

fix: ensure we always return undefined for invalid envs #25092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2025
Merged

fix: ensure we always return undefined for invalid envs #25092

merged 1 commit into from
May 20, 2025

Conversation

@karthiknadig
Copy link
Member

@karthiknadig karthiknadig commented May 20, 2025 •
edited
Loading

Fixes #25087

@karthiknadig karthiknadig self-assigned this May 20, 2025
@karthiknadig karthiknadig added bug Issue identified by VS Code Team member as probable bug skip tests Updates to tests unnecessary skip-issue-check skip package*.json package.json and package-lock.json don't both need updating labels May 20, 2025
@karthiknadig karthiknadig marked this pull request as ready for review May 20, 2025 15:16
@karthiknadig karthiknadig requested a review from DonJayamanne May 20, 2025 15:17
@karthiknadig karthiknadig enabled auto-merge (squash) May 20, 2025 15:17
@karthiknadig karthiknadig disabled auto-merge May 20, 2025 15:17
@karthiknadig karthiknadig enabled auto-merge (squash) May 20, 2025 15:17
@karthiknadig karthiknadig changed the title fix: ensure we alway return undefined for invalid envs fix: ensure we always return undefined for invalid envs May 20, 2025
@vs-code-engineering
Copy link

vs-code-engineering bot commented May 20, 2025

⚠️ This PR originates from a fork. Due to security restrictions, pipelines from forks are no longer triggered automatically. Learn more.

If the changes appear safe, you can manually trigger the pipeline by commenting /AzurePipelines run.

@vs-code-engineering vs-code-engineering bot added this to the May 2025 milestone May 20, 2025
@karthiknadig karthiknadig merged commit 020f203 into microsoft:main May 20, 2025
49 of 54 checks passed
@karthiknadig karthiknadig deleted the delete-bug branch May 20, 2025 20:24
anthonykim1 pushed a commit to anthonykim1/vscode-python that referenced this pull request Jun 5, 2025
@karthiknadig @anthonykim1
fix: ensure we always return undefined for invalid envs (microsoft#…
b81cd21 
…25092)

Fixes microsoft#25087
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DonJayamanne DonJayamanne DonJayamanne approved these changes

Assignees

@karthiknadig karthiknadig

Labels

bug Issue identified by VS Code Team member as probable bug skip package*.json package.json and package-lock.json don't both need updating skip tests Updates to tests unnecessary skip-issue-check

Projects

None yet

Milestone

May 2025

Development

Successfully merging this pull request may close these issues.

Cached Python Environments not cleared when deleting an env

2 participants

@karthiknadig @DonJayamanne