Skip to content

Remove single quotes surrounding displayed venv #25102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2025
Merged

Remove single quotes surrounding displayed venv #25102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
323a5f1
Remove single quotes surrounding displayed venv
cpinamtz May 22, 2025
cef4904
Merge branch 'main' into feature/remove_venv_quotes
cpinamtz May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/client/pythonEnvironments/nativeAPI.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,14 +112,14 @@ function getDisplayName(version: PythonVersion, kind: PythonEnvKind, arch: Archi
const kindStr = kindToShortString(kind);
if (arch === Architecture.x86) {
if (kindStr) {
return name ? `Python ${versionStr} 32-bit ('${name}')` : `Python ${versionStr} 32-bit (${kindStr})`;
return name ? `Python ${versionStr} 32-bit (${name})` : `Python ${versionStr} 32-bit (${kindStr})`;
}
return name ? `Python ${versionStr} 32-bit ('${name}')` : `Python ${versionStr} 32-bit`;
return name ? `Python ${versionStr} 32-bit (${name})` : `Python ${versionStr} 32-bit`;
}
if (kindStr) {
return name ? `Python ${versionStr} ('${name}')` : `Python ${versionStr} (${kindStr})`;
return name ? `Python ${versionStr} (${name})` : `Python ${versionStr} (${kindStr})`;
}
return name ? `Python ${versionStr} ('${name}')` : `Python ${versionStr}`;
return name ? `Python ${versionStr} (${name})` : `Python ${versionStr}`;
}

function validEnv(nativeEnv: NativeEnvInfo): boolean {
Expand Down
8 changes: 4 additions & 4 deletions src/test/pythonEnvironments/nativeAPI.unit.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@ suite('Native Python API', () => {
const expectedBasicEnv: PythonEnvInfo = {
arch: Architecture.Unknown,
id: '/usr/bin/python',
detailedDisplayName: "Python 3.12.0 ('basic_python')",
display: "Python 3.12.0 ('basic_python')",
detailedDisplayName: 'Python 3.12.0 (basic_python)',
display: 'Python 3.12.0 (basic_python)',
distro: { org: '' },
executable: { filename: '/usr/bin/python', sysPrefix: '/usr/bin', ctime: -1, mtime: -1 },
kind: PythonEnvKind.System,
Expand Down Expand Up @@ -98,8 +98,8 @@ suite('Native Python API', () => {

const expectedConda1: PythonEnvInfo = {
arch: Architecture.Unknown,
detailedDisplayName: "Python 3.12.0 ('conda_python')",
display: "Python 3.12.0 ('conda_python')",
detailedDisplayName: 'Python 3.12.0 (conda_python)',
display: 'Python 3.12.0 (conda_python)',
distro: { org: '' },
id: '/home/user/.conda/envs/conda_python/python',
executable: {
Expand Down