Skip to content

Commit 4f2eae4

Browse files
committed
follow mutable disposable store patterns
1 parent 5f74645 commit 4f2eae4

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

src/vs/workbench/contrib/chat/browser/chatInputPart.ts

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@ export class ChatInputPart extends Disposable implements IHistoryNavigationWidge
220220
private attachmentsContainer!: HTMLElement;
221221

222222
private chatInputOverlay!: HTMLElement;
223-
private readonly _overlayClickListener = this._register(new MutableDisposable<IDisposable>());
223+
private readonly overlayClickListener: MutableDisposable<DisposableStore>;
224224

225225
private attachedContextContainer!: HTMLElement;
226226
private readonly attachedContextDisposables: MutableDisposable<DisposableStore>;
@@ -393,6 +393,7 @@ export class ChatInputPart extends Disposable implements IHistoryNavigationWidge
393393
this.inputEditorHeight = 0;
394394
this.followupsDisposables = this._register(new DisposableStore());
395395
this.attachedContextDisposables = this._register(new MutableDisposable<DisposableStore>());
396+
this.overlayClickListener = this._register(new MutableDisposable<DisposableStore>());
396397
this._inputPartHeight = 0;
397398
this._followupsHeight = 0;
398399
this._editSessionWidgetHeight = 0;
@@ -1308,13 +1309,15 @@ export class ChatInputPart extends Disposable implements IHistoryNavigationWidge
13081309
public toggleChatInputOverlay(editing: boolean): void {
13091310
this.chatInputOverlay.classList.toggle('disabled', editing);
13101311
if (editing) {
1311-
this._overlayClickListener.value = dom.addStandardDisposableListener(this.chatInputOverlay, dom.EventType.CLICK, e => {
1312+
const store = new DisposableStore();
1313+
this.overlayClickListener.value = store;
1314+
store.add(dom.addStandardDisposableListener(this.chatInputOverlay, dom.EventType.CLICK, e => {
13121315
e.preventDefault();
13131316
e.stopPropagation();
13141317
this._onDidClickOverlay.fire();
1315-
});
1318+
}));
13161319
} else {
1317-
this._overlayClickListener.clear();
1320+
this.overlayClickListener.clear();
13181321
}
13191322
}
13201323

0 commit comments

Comments
 (0)