Merge pull request #285657 from murataslan1/fix/terminal-lifecycle

Fix: Replace terminal tabbed view lifecycle hack with Event.once

Author: Tyriar

src/vs/workbench/contrib/terminal/browser/terminalTabbedView.ts

@@ -592,13 +592,12 @@ export class TerminalTabbedView extends Disposable {
 		// be focused. So wait for connection to finish, then focus.
 		const previousActiveElement = this._tabListElement.ownerDocument.activeElement;
 		if (previousActiveElement) {
-			// TODO: Improve lifecycle management this event should be disposed after first fire
-			this._register(this._terminalService.onDidChangeConnectionState(() => {
+			const listener = this._register(Event.once(this._terminalService.onDidChangeConnectionState)(() => {
 				// Only focus the terminal if the activeElement has not changed since focus() was called
-				// TODO: Hack
 				if (dom.isActiveElement(previousActiveElement)) {
 					this._focus();
 				}
+				this._store.delete(listener);
 			}));
 		}
 	}