Skip to content

Conversation

pouyakary
Copy link
Contributor

As when you write node CLI software you have to include the UNIX header !# /bin/.. now TypeScript had no such support for that. Made a pull request for that in the TypeScript.tmLanguage repository but it seems that it's somehow out of maintenance and no one noticed it (also I see that my additions have syntax issues...) so I made a same change here with correct syntax and stuff.

As always hope it have helped.
Have so much fun!
Pouya

@msftclas
Copy link

Hi @pmkary, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@msftclas
Copy link

@pmkary, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@coveralls
Copy link

coveralls commented Aug 13, 2016

Coverage Status

Coverage remained the same at 62.509% when pulling 3d18b25 on pmkary:pouya/typescript-first-line-matching into 3efdbfd on Microsoft:master.

@aeschli
Copy link
Contributor

aeschli commented Aug 15, 2016

https://github.com/Microsoft/TypeScript-TmLanguage is the correct place for change requests to the tmLanguage files.

However, VSCode does not read the firstLine matches from tmLanguage files. This has to be configured in
https://github.com/Microsoft/vscode/blob/master/extensions/typescript/package.json#L38

@aeschli aeschli closed this Aug 15, 2016
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants