Update confirmations to use new proposed terminal style #260770
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roblourens
reviewed
Aug 9, 2025
| this._getUniqueCodeBlockUri(), | ||
| true | ||
| ); | ||
| textModelService.createModelReference(model.uri).then(ref => { |
There was a problem hiding this comment.
See my helper thenifNotDisposed
There was a problem hiding this comment.
The fact that we have to do this is confusing.
There was a problem hiding this comment.
I don't think I can use that since I need to call dispose on it to free the reference when the chat part is disposed?
...rib/chat/browser/chatContentParts/toolInvocationParts/chatTerminalToolConfirmationSubPart.ts
Outdated
Show resolved
Hide resolved
Tyriar
changed the title
|
THe last screenshot has odd word wrap 
|
|
@connor4312 mentioned that above, actually not a regression #260806 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #257468
Fixes #260705
Fixes #260776
Fixes #259088
This adds
ChatCustomConfirmationWidget2that aims to be this new style for all tools.I did not test the following:
InstallExtensionsTool/ExtensionsInstallConfirmationWidgetSubPartas it's not hooked up. Adoption for others didn't have any problems though.kind: 'confirmationtypes as defined in here, not sure where they show upInitial state:
Dropdown:
Delayed hover on command:
Terminal output polling:
Extension install (from copilot ext):
Task run:
Test run:
MCP (disclaimer wrapping is existing issue #260806):