-
Notifications
You must be signed in to change notification settings - Fork 38.4k
Show command descriptions as tooltips in Command Palette #284609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 9 commits
eaf4e38
5460ede
08dc81a
6558511
8e8e866
094452d
6e160fc
003afbe
41fe604
a31476a
425b92c
06f37d0
6771b82
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -27,6 +27,7 @@ import { IQuickAccessProviderRunOptions } from '../common/quickAccess.js'; | |
| import { IKeyMods, IQuickPickSeparator } from '../common/quickInput.js'; | ||
| import { IStorageService, StorageScope, StorageTarget, WillSaveStateReason } from '../../storage/common/storage.js'; | ||
| import { ITelemetryService } from '../../telemetry/common/telemetry.js'; | ||
| import { CommandsRegistry } from '../../commands/common/commands.js'; | ||
| import { Categories } from '../../action/common/actionCommonCategories.js'; | ||
|
|
||
| export interface ICommandQuickPick extends IPickerQuickAccessItem { | ||
|
|
@@ -274,6 +275,12 @@ export abstract class AbstractCommandsQuickAccessProvider extends PickerQuickAcc | |
| if (commandPick.type === 'separator') { | ||
| return commandPick; | ||
| } | ||
| if (!commandPick.tooltip && commandPick.commandDescription) { | ||
|
||
| commandPick = { | ||
| ...commandPick, | ||
| tooltip: commandPick.commandDescription.value | ||
| }; | ||
| } | ||
|
|
||
| const keybinding = this.keybindingService.lookupKeybinding(commandPick.commandId); | ||
| const ariaLabel = keybinding ? | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unused, please delete it