Skip to content

Conversation

@justschen
Copy link
Collaborator

@justschen justschen commented Jan 2, 2026

fix #285513

467-Magmortar

Copilot AI review requested due to automatic review settings January 2, 2026 08:22
@justschen justschen enabled auto-merge (squash) January 2, 2026 08:22
@vs-code-engineering vs-code-engineering bot added this to the December / January 2026 milestone Jan 2, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug where custom chat modes were not being properly preserved when editing previous requests. The fix updates mode synchronization to use mode IDs instead of mode kinds.

Key changes:

  • Changed from currentModeKind (enum value) to currentModeObs.get().id (string ID) when synchronizing chat modes
  • Applied to both directions: setting the editing input mode from the main input, and restoring the main input mode after editing

@justschen justschen merged commit 912018c into microsoft:main Jan 2, 2026
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modifying a chat message should use the chat mode it was using when it was made

2 participants