Skip to content

Conversation

@Tyriar
Copy link
Member

@Tyriar Tyriar commented Jan 2, 2026

npm scripts will be approved automatically with #285509. For npx we probably don't want to auto approve.

npm scripts will be approved automatically with #285509. For npx we probably don't want to auto approve.
@Tyriar Tyriar added this to the December / January 2026 milestone Jan 2, 2026
@Tyriar Tyriar self-assigned this Jan 2, 2026
Copilot AI review requested due to automatic review settings January 2, 2026 12:36
@Tyriar Tyriar enabled auto-merge January 2, 2026 12:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes auto-approve rules for npm and npx commands from the chat tools terminal configuration, as these will be handled automatically by #285509. The specific script-based auto-approvals (test.bat, test.sh, etc.) are retained.

Key Changes:

  • Removes regex-based auto-approve rule for npm test, npm lint, and npm run compile commands
  • Removes regex-based auto-approve rule for npx tsc commands with --noEmit flag

@Tyriar Tyriar merged commit 5203b17 into main Jan 2, 2026
34 checks passed
@Tyriar Tyriar deleted the Tyriar-patch-1 branch January 2, 2026 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants