chat: fix MCP tool confirmation quick tree hide timing #286235
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves the quickTree.hide() call inside the conditional block to ensure it only hides after the onDidOpen callback has been invoked for 'manage' items. This prevents the tree from closing prematurely before the manage action has completed. Fixes #275102 (Commit message generated by Copilot)
Contributor
There was a problem hiding this comment.
Pull request overview
This PR attempts to fix a timing issue where the quickTree would close prematurely before a manage action completed. It moves the quickTree.hide() call inside the conditional block that handles 'manage' type items.
Key Changes
- Moved
quickTree.hide()from after the loop to inside the conditional block for 'manage' items
src/vs/workbench/contrib/chat/browser/tools/languageModelToolsConfirmationService.ts
Show resolved
Hide resolved
pwang347
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the quickTree.hide() call inside the conditional block to ensure it
only hides after the onDidOpen callback has been invoked for 'manage' items.
This prevents the tree from closing prematurely before the manage action
has completed.
Fixes #275102
(Commit message generated by Copilot)