mcp: allow resource domains in script-src and style-src CSP #286690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes microsoft#286689 Fixes issue where MCP apps couldn't load external scripts and styles from domains specified in their CSP configuration. The resourceDomains are now properly included in both script-src and style-src directives.
connor4312
reviewed
Jan 9, 2026
...orkbench/contrib/chat/browser/widget/chatContentParts/toolInvocationParts/chatMcpAppModel.ts
Show resolved
Hide resolved
connor4312
approved these changes
Jan 9, 2026
Member
connor4312
left a comment
connor4312
left a comment
There was a problem hiding this comment.
Clarified in modelcontextprotocol/ext-apps#223 (comment) that this is a spec bug, so let's merge!
dmitrivMS
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #286689
This PR fixes an issue where MCP apps cannot load external scripts and stylesheets from domains specified in their CSP
resourceDomainsconfiguration.Changes
resourceDomainstoscript-srcCSP directive in chatMcpAppModel.ts:254resourceDomainstostyle-srcCSP directive in chatMcpAppModel.ts:255This aligns the CSP configuration for scripts and styles with the existing pattern already used for
img-srcandfont-src.Test Plan