Skip to content

Conversation

@hediet
Copy link
Member

@hediet hediet commented Jan 9, 2026

(see #285255)

FYI @connor4312

There is still this, which needs to be fixed:

"activationEvents": [
"workspaceContains:src/vs/loader.js"
],

Copilot AI review requested due to automatic review settings January 9, 2026 11:09
@hediet hediet enabled auto-merge (squash) January 9, 2026 11:09
@hediet hediet self-assigned this Jan 9, 2026
@hediet hediet disabled auto-merge January 9, 2026 11:09
@hediet hediet enabled auto-merge (squash) January 9, 2026 11:09
@hediet hediet requested a review from connor4312 January 9, 2026 11:09
@vs-code-engineering vs-code-engineering bot added this to the January 2026 milestone Jan 9, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the VS Code workspace detection logic to use package.json instead of checking for the existence of src/vs/loader.js. The new approach reads the package.json file and verifies the workspace by checking if the name field equals code-oss-dev, making the detection more reliable and explicit.

Key changes:

  • Replaced file existence check (src/vs/loader.js) with package.json name validation
  • Extracted detection logic into a new isVsCodeWorkspaceFolder function for better modularity
  • Applied minor code formatting updates to empty braces

@hediet hediet merged commit e67d7c9 into main Jan 9, 2026
27 of 28 checks passed
@hediet hediet deleted the hediet/b/sick-rook branch January 9, 2026 16:29
@connor4312
Copy link
Member

This would actually be fine to activate onStartupFinished or * because it's now a workspace extension and we know it'll always be relevant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants