Skip to content

Do not override ctrl+shift+g #286831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anthonykim1 merged 2 commits into from
Jan 10, 2026
Merged

Do not override ctrl+shift+g #286831

anthonykim1 merged 2 commits into from
Jan 10, 2026
+4 −4

Conversation

@anthonykim1
Copy link
Contributor

@anthonykim1 anthonykim1 commented Jan 9, 2026 •
edited
Loading

Solves: #286825

@anthonykim1 anthonykim1 added this to the December 2025 Recovery 1 milestone Jan 9, 2026
@anthonykim1 anthonykim1 self-assigned this Jan 9, 2026
Copilot AI review requested due to automatic review settings January 9, 2026 21:04
@anthonykim1 anthonykim1 added the candidate Issue identified as probable candidate for fixing in the next release label Jan 9, 2026
Copilot AI reviewed Jan 9, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR resolves a keybinding conflict by removing the Ctrl+Shift+G keybinding override for the "Announce Cursor Position" accessibility command. The keybinding was conflicting with the Source Control view (which uses Ctrl+Shift+G on Windows and Linux). The command is now consistently bound to Ctrl+Alt+Shift+G across all platforms instead of having platform-specific variations.

  • Unified the keybinding to Ctrl+Alt+Shift+G across all platforms (previously Ctrl+Shift+G on non-Windows, Ctrl+Alt+Shift+G on Windows)
  • Resolves conflict with SCM (Source Control) view keybinding

@anthonykim1 anthonykim1 marked this pull request as ready for review January 9, 2026 23:21
@anthonykim1 anthonykim1 requested a review from meganrogge January 9, 2026 23:21
@Tyriar Tyriar removed the candidate Issue identified as probable candidate for fixing in the next release label Jan 10, 2026
@anthonykim1 anthonykim1 enabled auto-merge (squash) January 10, 2026 02:47
@anthonykim1 anthonykim1 disabled auto-merge January 10, 2026 02:48
@anthonykim1 anthonykim1 reopened this Jan 10, 2026
@anthonykim1 anthonykim1 enabled auto-merge (squash) January 10, 2026 02:48
@anthonykim1 anthonykim1 merged commit 8a6ad6e into main Jan 10, 2026
37 checks passed
@anthonykim1 anthonykim1 deleted the anthonykim1/candidateCtrlShiftG branch January 10, 2026 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@Tyriar Tyriar Tyriar approved these changes

@meganrogge meganrogge meganrogge approved these changes

Assignees

@anthonykim1 anthonykim1

Labels

None yet

Projects

None yet

Milestone

December 2025 Recovery 1

Development

Successfully merging this pull request may close these issues.

4 participants

@anthonykim1 @Tyriar @meganrogge