Skip to content

Try publishing artifacts #286846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TylerLeonhardt wants to merge 4 commits into from
Closed

Try publishing artifacts #286846

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
241d51a
Try publishing artifacts
TylerLeonhardt Jan 9, 2026
fe5702b
ok
TylerLeonhardt Jan 9, 2026
92d3f3e
last try
TylerLeonhardt Jan 9, 2026
590b3ae
hard coded
TylerLeonhardt Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions .github/workflows/pr-darwin-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,28 @@ jobs:
path: node_modules
if-no-files-found: ignore

- name: Find Playwright Trace
id: find-trace
if: failure()
continue-on-error: true
run: |
trace=$(find .build/logs -name 'playwright-trace-*.zip' -print -quit 2>/dev/null || true)
if [ -n "$trace" ]; then
echo "trace=$trace" >> $GITHUB_OUTPUT
echo "Found trace: $trace"
else
echo "No trace found"
fi

- name: Publish Playwright Trace
if: failure() && steps.find-trace.outputs.trace
continue-on-error: true
uses: actions/upload-artifact@v6
with:
name: playwright-trace-1-verifies_that_application_launches_when_user_data_directory_has_non-ascii_characters.zip
path: ${{ steps.find-trace.outputs.trace }}
if-no-files-found: ignore

- name: Publish Log Files
uses: actions/upload-artifact@v6
if: always()
Expand Down
1 change: 1 addition & 0 deletions test/smoke/src/areas/workbench/launch.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ export function setup(logger: Logger) {
it('verifies that application launches when user data directory has non-ascii characters', async function () {
const app = this.app as Application;
await app.workbench.explorer.openExplorerView();
throw new Error('Intentional test failure for testing Playwright traces');
Copy link

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This intentional test failure should not be committed to the repository. This appears to be a temporary change for testing the Playwright trace artifact upload mechanism and should be removed before merging.

Suggested change
throw new Error('Intentional test failure for testing Playwright traces');

Copilot uses AI. Check for mistakes.
});
});
}
Loading