Skip to content

If the users selects a language, let's have it actually choose the language they selected. (Yaml vs yaml) #288153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bpasero merged 3 commits into from
Jan 16, 2026
+2 −2
Merged

If the users selects a language, let's have it actually choose the language they selected. (Yaml vs yaml) #288153

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a85dbb0
If the users selects a language, let's have it actually choose the la…
Infro Jan 15, 2026
4bf6364
Merge remote-tracking branch 'upstream/main' into fix-language-select…
Infro Jan 15, 2026
5f0e7c5
polish
bpasero Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/vs/workbench/browser/parts/editor/editorStatus.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1201,7 +1201,8 @@ export class ChangeLanguageAction extends Action2 {
label: languageName,
meta: extensions,
iconClasses: getIconClassesForLanguageId(languageId),
description
description,
id: languageId
};
});

Expand Down Expand Up @@ -1280,8 +1281,7 @@ export class ChangeLanguageAction extends Action2 {
}
}
} else {
const languageId = languageService.getLanguageIdByLanguageName(pick.label);
languageSelection = languageService.createById(languageId);
languageSelection = languageService.createById(pick.id!);

if (resource) {
// fire and forget to not slow things down
Expand Down