fix: memory leak in extension host editor tabs #288404
Draft
+57
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #288393
Details
Unfortunately I don't have much details in this case. I asked the AI to fix the potential memory leak in
ExtensionHostEditorTaband this is the output. And it seems to work for some reason...But I wouldn't want to merge this PR without understanding what's going on exactly. Feedback appreciated!
Before
When opening editor tabs, doing a cross file rename and closing tabs 197 times, the number of
ExtensionHostEditorTabseems to grow each time:After
No more function leak is detected.