The 'excludeAgent' attribute must be an array #291924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonykim1
approved these changes
Jan 30, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a validation issue where the excludeAgent attribute in instruction files was only accepting arrays, but GitHub's documentation indicates it should also accept strings. The fix updates the validation logic to accept both types.
Changes:
- Modified the type validation for
excludeAgentattribute to accept both string and array types - Updated the error message to reflect that either string or array is acceptable
| if (attribute.value.type !== 'array') { | ||
| report(toMarker(localize('promptValidator.excludeAgentMustBeArray', "The 'excludeAgent' attribute must be an array."), attribute.value.range, MarkerSeverity.Error)); | ||
| if (attribute.value.type !== 'array' && attribute.value.type !== 'string') { | ||
| report(toMarker(localize('promptValidator.excludeAgentMustBeArray', "The 'excludeAgent' attribute must be an string or array."), attribute.value.range, MarkerSeverity.Error)); |
There was a problem hiding this comment.
Grammar error in the error message. The article "an" should be "a" before "string" since "string" starts with a consonant sound.
Suggested change
| report(toMarker(localize('promptValidator.excludeAgentMustBeArray', "The 'excludeAgent' attribute must be an string or array."), attribute.value.range, MarkerSeverity.Error)); | |
| report(toMarker(localize('promptValidator.excludeAgentMustBeArray', "The 'excludeAgent' attribute must be a string or array."), attribute.value.range, MarkerSeverity.Error)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #277642