Skip to content

Clean up model picker input styles#298460

Merged
daviddossett merged 2 commits intomainfrom
ddossett/visiting-catfish
Feb 28, 2026
Merged

Clean up model picker input styles#298460
daviddossett merged 2 commits intomainfrom
ddossett/visiting-catfish

Conversation

@daviddossett
Copy link
Collaborator

Cleans up leftover model picker input styles after the focus outline removal:

  • Remove background color from the filter input (was left behind when focus outlines were removed)
  • Add spacing below the filter separator to match the gap between the last model item and the "Other models" separator section

Copilot AI review requested due to automatic review settings February 28, 2026 17:04
@daviddossett daviddossett marked this pull request as ready for review February 28, 2026 17:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the Chat model picker dropdown’s filter input styling to better match the action widget’s visual design after prior focus-outline changes.

Changes:

  • Makes the model picker filter input background transparent.
  • Adds extra spacing below the filter area by applying a margin to its container.
  • Adds a runtime class to the filter container to target the new spacing rule.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/vs/workbench/contrib/chat/browser/widget/media/chat.css Removes filter input background and adds container margin styling for spacing.
src/vs/workbench/contrib/chat/browser/widget/input/chatModelPicker.ts Adds a CSS class to the filter container at runtime to enable the new spacing rule.

@daviddossett daviddossett changed the title Clean up model picker input styles: remove background, add filter spacing Clean up model picker input styles Feb 28, 2026
@daviddossett daviddossett enabled auto-merge (squash) February 28, 2026 17:28
@daviddossett daviddossett merged commit aa70284 into main Feb 28, 2026
20 checks passed
@daviddossett daviddossett deleted the ddossett/visiting-catfish branch February 28, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants