Skip to content

Clear previous sync action before registering a new one in GitSyncCon…#298898

Open
benibenj wants to merge 1 commit intomainfrom
copilot-worktree-2026-03-02T21-11-51
Open

Clear previous sync action before registering a new one in GitSyncCon…#298898
benibenj wants to merge 1 commit intomainfrom
copilot-worktree-2026-03-02T21-11-51

Conversation

@benibenj
Copy link
Contributor

@benibenj benibenj commented Mar 3, 2026

No description provided.

Copilot AI review requested due to automatic review settings March 3, 2026 08:09
@vs-code-engineering vs-code-engineering bot added this to the March 2026 milestone Mar 3, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a command registration error in the Agent Sessions Git Sync contribution by ensuring the previous sync action is disposed before a new one is registered, preventing duplicate command IDs in registerAction2.

Changes:

  • Clear the previously registered sync action disposable before registering a new sync action.
  • Ensure the sync action registration lifecycle is reset whenever the upstream/ahead/behind state is recomputed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants