Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Sessions window logs contribution to make the Output/Logs view available without requiring an explicit “Show Logs” command/context-key gate.
Changes:
- Removes the
sessionsShowLogscontext key and thewhencondition that previously gated visibility of the logs/output view. - Deletes the “Sessions: Show Logs” command that set the context key and opened the Output view.
| @@ -32,7 +26,6 @@ class RegisterLogsViewContainerContribution implements IWorkbenchContribution { | |||
| constructor( | |||
| @IContextKeyService contextKeyService: IContextKeyService, | |||
| ) { | |||
There was a problem hiding this comment.
IContextKeyService is no longer used (the context key gating was removed), but the constructor still injects it. With noUnusedParameters enabled, this will cause a compile error. Remove the @IContextKeyService contextKeyService parameter (and the import) or actually use it.
| ctorDescriptor: new SyncDescriptor(OutputViewPane), | ||
| canToggleVisibility: true, | ||
| canMoveView: false, | ||
| when: CONTEXT_SESSIONS_SHOW_LOGS, | ||
| windowVisibility: WindowVisibility.Sessions, | ||
| }], logsViewContainer); |
There was a problem hiding this comment.
The inline comment just above this view registration says it is registered “with a when context”, but the when condition was removed in this change. Please update/remove that comment so it matches the current behavior.
No description provided.