Skip to content

sessions - improve session hover title rendering and persistence#298950

Merged
bpasero merged 9 commits intomainfrom
ben/copilot-worktree-2026-03-03T11-10-33
Mar 3, 2026
Merged

sessions - improve session hover title rendering and persistence#298950
bpasero merged 9 commits intomainfrom
ben/copilot-worktree-2026-03-03T11-10-33

Conversation

@bpasero
Copy link
Member

@bpasero bpasero commented Mar 3, 2026

No description provided.

Copilot AI review requested due to automatic review settings March 3, 2026 12:49
@bpasero bpasero enabled auto-merge (squash) March 3, 2026 12:49
@bpasero bpasero marked this pull request as draft March 3, 2026 12:50
auto-merge was automatically disabled March 3, 2026 12:50

Pull request was converted to draft

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refines how session item hovers are configured and rendered, particularly for the Sessions window, by replacing a misleading disableHover option with a clearer useSimpleHover option and wiring it up to render a lightweight title hover instead of the richer session hover widget.

Changes:

  • Rename the session list hover option from disableHover to useSimpleHover.
  • When useSimpleHover is enabled, render a plain-text title hover for session items.
  • Enable useSimpleHover in the Sessions view pane configuration.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsViewer.ts Renames the renderer option and switches the hover branch to render a simple title hover when enabled.
src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsControl.ts Renames the control options field to match the new renderer option.
src/vs/sessions/contrib/sessions/browser/sessionsViewPane.ts Updates Sessions window usage to opt into the simple hover behavior.

@bpasero bpasero marked this pull request as ready for review March 3, 2026 12:57
@bpasero bpasero enabled auto-merge (squash) March 3, 2026 12:57
@bpasero bpasero self-assigned this Mar 3, 2026
@bpasero bpasero added this to the March 2026 milestone Mar 3, 2026
lszomoru
lszomoru previously approved these changes Mar 3, 2026
@bpasero bpasero merged commit ff7ffa5 into main Mar 3, 2026
20 checks passed
@bpasero bpasero deleted the ben/copilot-worktree-2026-03-03T11-10-33 branch March 3, 2026 16:04
mrleemurray pushed a commit that referenced this pull request Mar 3, 2026
…8950)

* fix - add title rendering for session hover

* fix - update hover title rendering logic

* fix - update hover persistence for session rendering

* fix - update hover setup for agent sessions

* fix - update hover handling in `agentSessions`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants