Indicate when all sessions are filtered hidden (fix #296581)#298979
Merged
Indicate when all sessions are filtered hidden (fix #296581)#298979
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the Agent Sessions viewer UX by showing an explicit message when the sessions list becomes empty due to active filtering, and offering a “Clear Filters” action (fixing #296581).
Changes:
- Extend
IAgentSessionsFilterwithisDefault()andreset()to support UI-driven filter reset and “filter active” detection. - Add a
onDidGetChildrenevent toAgentSessionsDataSourceand use it inAgentSessionsControlto toggle an empty-results message when filtering hides all sessions. - Update styling and unit tests to align with the new filter/data source behavior and disposal requirements.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsViewer.ts |
Extends filter API and makes the data source disposable with an event to report filtered child counts. |
src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsControl.ts |
Adds and toggles an “empty due to filter” message with a “Clear Filters” action. |
src/vs/workbench/contrib/chat/browser/agentSessions/media/agentsessionsviewer.css |
Styles the new empty-filter message and its action link. |
src/vs/workbench/contrib/chat/test/browser/agentSessions/agentSessionsDataSource.test.ts |
Updates mocks/disposal to match the new IAgentSessionsFilter and disposable data source. |
src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsControl.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/chat/browser/agentSessions/media/agentsessionsviewer.css
Show resolved
Hide resolved
src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsFilter.ts
Show resolved
Hide resolved
…tsessionsviewer.css Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsControl.ts
Show resolved
Hide resolved
src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsControl.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/chat/browser/widgetHosts/viewPane/media/chatViewPane.css
Show resolved
Hide resolved
…onsControl.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
jrieken
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.