Skip to content

Fix /hooks slash command from blocking chat #299084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pwang347 merged 2 commits into from
Mar 4, 2026
Merged

Fix /hooks slash command from blocking chat #299084

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88fafcd
fix
pwang347 Mar 3, 2026
4589a9b
actual fix
pwang347 Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/vs/workbench/contrib/chat/common/chatService/chatServiceImpl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1121,6 +1121,12 @@ export class ChatService extends Disposable implements IChatService {
if (commandPart.slashCommand.silent !== true) {
request = model.addRequest(parsedRequest, { variables: [] }, attempt, options?.modeInfo);
completeResponseCreated();
} else {
// Silent slash commands (e.g. /hooks, /skills) may open UI like
// quick picks that await user interaction. Remove the pending
// request entry so that the chat input is not blocked while
// the command's UI is open.
this._pendingRequests.deleteAndDispose(sessionResource);
}
// contributed slash commands
// TODO: spell this out in the UI
Expand Down
Loading