Fix issue #14993 about forward slashes not working on windows when globbing sources#15002
Closed
DavidVilleneuveAnsys wants to merge 1 commit intomicrosoft:mainfrom
Closed
Conversation
🐛: Using a list of allowed separators (alternate + normal) to search for instead of only using the main separators
Member
|
Please accept the CLA if you agree with it. Otherwise I cannot proceed. |
Member
|
making it a draft, waiting for @DavidVilleneuveAnsys to confirm CLA |
Member
|
Closing without deleting the branch, can't take your code without approving CLA. Please comment below if you'd like to continue on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛: Using a list of allowed separators (alternate + normal) to search for instead of only using the main separators
Description
To retrieve the source where we start the globbing pattern, the pattern is first split, then we search for the first Directory separator.
In this search, we only allow for the the principal separator, however, some platforms have alternate separators.
So we use
LastIndexOfAnyinstead ofLastIndexOfRelated issue
Issue being fixed is here #14993 and is flagged as a bug