Skip to content

Update matrix#15477

Merged
nohwnd merged 33 commits intomicrosoft:mainfrom
nohwnd:update-matrix
Mar 16, 2026
Merged

Update matrix#15477
nohwnd merged 33 commits intomicrosoft:mainfrom
nohwnd:update-matrix

Conversation

@nohwnd
Copy link
Member

@nohwnd nohwnd commented Mar 10, 2026

Description

Update versions. Look at how to do this automatically later.

Related issue

Fix #15475

Copilot AI review requested due to automatic review settings March 10, 2026 21:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the test/compatibility matrix by bumping framework/tooling versions and adjusting MSTest execution settings in test assets.

Changes:

  • Updated NUnit and MSTest version properties used by compatibility/test-asset builds.
  • Updated VSTest console version properties used for compatibility testing.
  • Added MSTest assembly-level parallelization configuration to two test asset projects.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
test/TestAssets/MSTestProject2/UnitTest1.cs Adds assembly-level MSTest parallelization configuration to influence test execution behavior.
test/TestAssets/MSTestProject1/UnitTest1.cs Adds assembly-level MSTest parallelization configuration to influence test execution behavior.
eng/Versions.props Bumps NUnit/MSTest/VSTest versions used by build/test compatibility matrices.

nohwnd and others added 2 commits March 10, 2026 22:57
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 11, 2026 07:30
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

@nohwnd
Copy link
Member Author

nohwnd commented Mar 11, 2026

needs #15480 where we are using only recent vstest.console to run compatibility checks on vstest.console, this avoids needing the old runtimes which we remove here.

(testhost does not need the runtime, because we pass runtime.config.json of the project, if someone is using netcoreapp2.1 that is their fault and they should update from this unsupported version of .NET)

@nohwnd
Copy link
Member Author

nohwnd commented Mar 11, 2026

The other errors I don't know yet. Need to merge stuff first, too many moving parts right now.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 12, 2026 07:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

nohwnd added 11 commits March 13, 2026 14:27
# Conflicts:
#	eng/build.ps1
#	test/Microsoft.TestPlatform.Acceptance.IntegrationTests/TestCaseFilterTests.cs
#	test/Microsoft.TestPlatform.Library.IntegrationTests/AppDomainTests.cs
#	test/Microsoft.TestPlatform.Library.IntegrationTests/TranslationLayerTests/CodeCoverageTests.cs
#	test/Microsoft.TestPlatform.TestUtilities/IntegrationTestBuild.cs
Copilot AI review requested due to automatic review settings March 16, 2026 11:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

eng/build.ps1:1

  • If the caller already passed -properties as a single string, $PSBoundParameters['properties'] will be a string and += will concatenate into a single malformed value rather than append a new property entry. Consider normalizing to an array in both cases (e.g., wrap the existing value with @(...)) before appending, so the splatted -properties argument remains a proper list.
[CmdletBinding(PositionalBinding = $false)]

@nohwnd nohwnd marked this pull request as ready for review March 16, 2026 13:55
Copilot AI review requested due to automatic review settings March 16, 2026 13:55
$PSBoundParameters['properties'] = @()
}
$PSBoundParameters['properties'] += "/p:TestRunnerExternalArguments=$filterString $testParameterString"
Write-Host "Running tests with filter: $filterString and additional parameters: $testParameterString"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added that in previous pr, it is not useful.

@@ -89,30 +89,30 @@
<XUnitFrameworkVersion>2.4.2</XUnitFrameworkVersion>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating xunit will be more pain probably, keeping for later.

@nohwnd
Copy link
Member Author

nohwnd commented Mar 16, 2026

aaaargh, it re-runs the build when I change it from draft. I always forget. It was almost green on mac tests....

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

@nohwnd nohwnd merged commit 056f792 into microsoft:main Mar 16, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update versions of tested dependencies

3 participants