Conversation
There was a problem hiding this comment.
Pull request overview
Updates the test/compatibility matrix by bumping framework/tooling versions and adjusting MSTest execution settings in test assets.
Changes:
- Updated NUnit and MSTest version properties used by compatibility/test-asset builds.
- Updated VSTest console version properties used for compatibility testing.
- Added MSTest assembly-level parallelization configuration to two test asset projects.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| test/TestAssets/MSTestProject2/UnitTest1.cs | Adds assembly-level MSTest parallelization configuration to influence test execution behavior. |
| test/TestAssets/MSTestProject1/UnitTest1.cs | Adds assembly-level MSTest parallelization configuration to influence test execution behavior. |
| eng/Versions.props | Bumps NUnit/MSTest/VSTest versions used by build/test compatibility matrices. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
needs #15480 where we are using only recent vstest.console to run compatibility checks on vstest.console, this avoids needing the old runtimes which we remove here. (testhost does not need the runtime, because we pass runtime.config.json of the project, if someone is using netcoreapp2.1 that is their fault and they should update from this unsupported version of .NET) |
|
The other errors I don't know yet. Need to merge stuff first, too many moving parts right now. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…stest into split-integration-tests
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…stest into split-integration-tests
# Conflicts: # eng/build.ps1 # test/Microsoft.TestPlatform.Acceptance.IntegrationTests/TestCaseFilterTests.cs # test/Microsoft.TestPlatform.Library.IntegrationTests/AppDomainTests.cs # test/Microsoft.TestPlatform.Library.IntegrationTests/TranslationLayerTests/CodeCoverageTests.cs # test/Microsoft.TestPlatform.TestUtilities/IntegrationTestBuild.cs
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
eng/build.ps1:1
- If the caller already passed
-propertiesas a single string,$PSBoundParameters['properties']will be a string and+=will concatenate into a single malformed value rather than append a new property entry. Consider normalizing to an array in both cases (e.g., wrap the existing value with@(...)) before appending, so the splatted-propertiesargument remains a proper list.
[CmdletBinding(PositionalBinding = $false)]
| $PSBoundParameters['properties'] = @() | ||
| } | ||
| $PSBoundParameters['properties'] += "/p:TestRunnerExternalArguments=$filterString $testParameterString" | ||
| Write-Host "Running tests with filter: $filterString and additional parameters: $testParameterString" |
There was a problem hiding this comment.
I added that in previous pr, it is not useful.
| @@ -89,30 +89,30 @@ | |||
| <XUnitFrameworkVersion>2.4.2</XUnitFrameworkVersion> | |||
There was a problem hiding this comment.
Updating xunit will be more pain probably, keeping for later.
|
aaaargh, it re-runs the build when I change it from draft. I always forget. It was almost green on mac tests.... |
Description
Update versions. Look at how to do this automatically later.
Related issue
Fix #15475