Skip to content

Check for Python installation before generating C++ addons #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
azchohfi merged 2 commits into from
Dec 9, 2025
Merged

Check for Python installation before generating C++ addons #180

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5df568
Check for Python installation before generating C++ addons
azchohfi Dec 4, 2025
46a0ed1
Merge branch 'main' into alzollin/pythonCheck
JesseCol Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions src/winapp-npm/cli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,13 @@ async function handleCreateAddon(args) {
console.log(` 2. npm run build-${result.addonName}`);
console.log(` 3. See ${result.addonName}/README.md for usage examples`);
} else {

if (!await pythonExists()) {
console.error(`❌ Python is required to generate C++ addons but was not found in your PATH.`);
console.error(` Please install Python (version 3.10 or later) and ensure it is accessible from the command line.`);
process.exit(1);
}

// Use C++ addon generator (existing)
result = await generateAddonFiles({
name: options.name,
Expand All @@ -287,6 +294,26 @@ async function handleCreateAddon(args) {
}
}

function pythonExists() {
const commands = ["python --version", "python3 --version", "py --version"];

return new Promise(resolve => {
let index = 0;

function tryNext() {
if (index >= commands.length) return resolve(false);

exec(commands[index], (err) => {
if (!err) return resolve(true);
index++;
tryNext();
});
}

tryNext();
});
}

async function handleAddonElectronDebugIdentity(args) {
const options = parseArgs(args, {
verbose: true
Expand Down