Skip to content

Managed addon now uses dotnet 10 by default and Windows 26100 #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
azchohfi merged 2 commits into from
Dec 9, 2025
Merged

Managed addon now uses dotnet 10 by default and Windows 26100 #182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0330050
Managed addon now uses dotnet 10 by default and Windows 26100
JesseCol Dec 8, 2025
20f6da2
Merge branch 'main' into jessecol/addon-uses-dotnet10
JesseCol Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion samples/electron/csAddon/csAddon.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net8.0-windows10.0.19041.0</TargetFramework>
<TargetFramework>net10.0-windows10.0.26100.0</TargetFramework>
<OutputType>Library</OutputType>
<AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>
<AssemblyName>csAddon</AssemblyName>
Expand Down
7 changes: 0 additions & 7 deletions samples/electron/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/winapp-npm/cs-addon-template/AddonTemplate.csproj.template
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net8.0-windows10.0.19041.0</TargetFramework>
<TargetFramework>net10.0-windows10.0.26100.0</TargetFramework>
<OutputType>Library</OutputType>
<AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>
<AssemblyName>{AddonName}</AssemblyName>
Expand Down
4 changes: 2 additions & 2 deletions src/winapp-npm/cs-addon-template/Directory.packages.props.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<PackageVersion Include="Microsoft.JavaScript.NodeApi.Generator" Version="0.9.17" />

<!-- These versions may be updated automatically during restore to match yaml -->
<PackageVersion Include="Microsoft.WindowsAppSDK" Version="Run restore to set version before building" />
<PackageVersion Include="Microsoft.Windows.SDK.BuildTools" Version="Run restore to set version before building" />
<PackageVersion Include="Microsoft.WindowsAppSDK" Version="Run winapp restore to set version before building" />
<PackageVersion Include="Microsoft.Windows.SDK.BuildTools" Version="Run winapp restore to set version before building" />
</ItemGroup>
</Project>