Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an end-to-end test for the Electron workflow that validates the complete WinApp CLI workflow from app creation through MSIX packaging. Additionally, it extends the add-electron-debug-identity command with --no-install and --manifest options to support CI/testing scenarios.
Changes:
- Added comprehensive E2E test script (
test-e2e-electron.ps1) that creates an Electron app, initializes WinApp, creates/builds native addons, adds debug identity, and packages to MSIX - Extended
add-electron-debug-identitycommand with--no-installand--manifestoptions for greater flexibility - Enhanced npm path resolution in addon utilities to work correctly in CI environments
- Added GitHub Actions workflow job to run E2E test on every build
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
scripts/test-e2e-electron.ps1 |
New comprehensive E2E test script for Electron workflow with retry logic, cleanup, and detailed logging |
src/winapp-npm/src/msix-utils.ts |
Added noInstall and manifest options to MsixIdentityOptions interface and addElectronDebugIdentity function |
src/winapp-npm/src/cs-addon-utils.ts |
Enhanced npm path resolution to use the npm binary co-located with the running Node.js process |
src/winapp-npm/src/cpp-addon-utils.ts |
Enhanced npm path resolution to use the npm binary co-located with the running Node.js process |
src/winapp-npm/src/cli.ts |
Added argument parsing and help text for new --no-install and --manifest options |
src/winapp-CLI/WinApp.Cli/Services/MsixService.cs |
Modified Developer Mode check to skip when noInstall is true |
docs/usage.md |
Added documentation for new --manifest option |
.gitignore |
Added test-wd/ directory to ignore list |
.github/workflows/build-package.yml |
Added new e2e-test job that runs after build completion |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
azchohfi
requested changes
Jan 21, 2026
azchohfi
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #241