-
Notifications
You must be signed in to change notification settings - Fork 585
Add --sys-fn-ptrs
for windows-sys fn ptr types
#3782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
817a3f3
to
ce07877
Compare
@microsoft-github-policy-service agree (shouldn't be necessary since I'm a MSFT employee but 🤷) |
@microsoft-github-policy-service agree company="Microsoft" |
2f85944
to
8dee533
Compare
8dee533
to
b4c358d
Compare
--sys-fn-ptrs
for windows-sys fn ptr types
--sys-fn-ptrs
for windows-sys fn ptr types--sys-fn-ptrs
for windows-sys fn ptr types
Updated so that if you specify Also attempted and hopefully successfully added a test for it. Not really familiar with the CI process here but I think the system yelled at me enough to get it mostly right? This is my first Rust code that isn't just me playing around on toy projects, so happy to take any feedback around best practices that I may be ignorant of 😀. |
https://github.com/uint-nate/pluginrust/blob/master/bindings/src/bindings.rs is updated to use this new binding code. |
The current failures aren't coming from my code FWIW. If you want me to address them I can look into them though if that's the normal flow of things. Not sure if there was a library update or something. |
That's a common problem as CI tests against Rust nightly builds as an early warning system. This PR is now blocked on #3789 where I address this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - thanks!
Potential solution for #3781
For reference, I used code built on this to generate the following bindings: https://github.com/uint-nate/pluginrust/blob/master/bindings/src/bindings.rs