Don't put ARP version data into tracking catalog #4964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yao-msft
previously approved these changes
Nov 13, 2024
yao-msft
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
A previous change was made to block overlapping ARP ranges being put into the index. The fact that this was potentially impactful to the tracking catalog was put off until now.
This change removes ARP version information (when present) from the manifest before placing it into the tracking catalog. We are not using this data, and I don't see a reason that we would. Attempting to preserve it would probably require removing all existing ARP version information when adding/updating the tracking manifest.
Validation
Added a test that to insert an overlapping range into the tracking catalog.
Microsoft Reviewers: Open in CodeFlow