Enable intellisense for all user settings fields #5031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yao-msft
approved these changes
Dec 12, 2024
roxterrr1
pushed a commit
to roxterrr1/winget-cli
that referenced
this pull request
Dec 15, 2024
roxterrr1
pushed a commit
to roxterrr1/winget-cli
that referenced
this pull request
Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In VSCode, I don't get Intellisense for all user settings fields. This seems to be because all fields are not defined under
allOf:. PR adds missing fields underallOf:to enable intellisense. The diffs may be weird as it seems the file contains mixed line endings. I just let everything be inLFto avoid showing the whole file changed in git diff. Moved Source field up inallOf:to follow the same ordering as defined underdefinitions:Validation
Manually validated that I'm getting intellisense for missing fields against the URL in my branch
Microsoft Reviewers: Open in CodeFlow