Test host for in-proc COM module validation #5910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

JohnMcPMS merged 15 commits into microsoft:master from JohnMcPMS:inproc-testbed

Dec 15, 2025

+1,894 −136

Member

JohnMcPMS commented Dec 5, 2025 •

edited by microsoft-github-policy-service bot

Loading

Fixes #5869 and #5870 in the current code and will be backported to 1.12

Change

Adds a test host that leverages the in-proc COM module (as built locally) to validate various lifetime management scenarios. It has numerous options for controlling the scenarios, as well as an extensible model for adding different tests in the future.

It was able to hit the faults described in the linked issues, and the fixes are included:

Move the ServerShutdownSynchronization to integrate with the signal monitoring directly, rather than registering as an object. This also means that there is no need to unregister, preventing the construction of a TerminationSignalHandler.
Remove the call that terminates COM objects from the DLL_PROCESS_DETACH handler. If the caller is using the module properly via COM, the DllCanUnloadNow calls should take care of things. If the process is exiting without that call, leaking objects will be fine (the caller didn't uninitialize COM, so it is doubtful they care about a clean exit).

Additionally, these changes were made to support additional scenarios:

Add the WinRT type names to the manifest file so that WinRT activation can work.
Fix the activation factories to be counted objects for the module.
Add a setting that allows the caller to prevent DllCanUnloadNow from checking the object state, always returning that it cannot unload now. This can be used to prevent the module from being unloaded (and any active static objects alive) even if no external objects are active.

Validation

The test host is run with various parameters as part of the E2E tests.
The linked issues are represented within the set of tests, as are several other scenarios.

Microsoft Reviewers: Open in CodeFlow

JohnMcPMS added 13 commits

November 10, 2025 17:17


          create project

2e00bcd


          Merge branch 'master' into inproc-testbed

1cfaecf


          Get project set up, needs COM activation by CLSID?

cb16ad7


          Basics set up

92c88d0


          Mostly done but needs generic resource usage monitoring

ea65b16


          Better tests design

40d7274


          Refactor test parameters and make activation factories counted objects

325bd80


          Implement activation type, update tests

26580af


          Allow for source update and start adding to E2E tests

fc5805f


          More tests work, added new test that is not quite done

ff64219


          Add test invocations and fix some test things


          Merge branch 'master' into inproc-testbed

d2714f0


          Spelling and proj update

1882f6c

JohnMcPMS requested a review from a team as a code owner

December 5, 2025 20:44

dkbennett previously approved these changes

View reviewed changes

src/AppInstallerCLIE2ETests/InprocTestbedTests.cs

+                          });
+                      }
+                      private void RunInprocTestbed(TestbedParameters parameters, int timeout = 300000)

Member

dkbennett Dec 8, 2025

Might be nice to have default timeout constant defined, though it looks like this is the only place it is referenced. This 5m seems like a good number since we've seen other tests hit 2m randomly.


          Copy testbed in pipeline; initialize signal handler in server process…

41fdf50

…; use explicit test package parameter in tests

JohnMcPMS dismissed dkbennett’s stale review via

41fdf50

December 9, 2025 00:48


          Improve project reference copying to hopefully work in pipeline

26d9785

florelis approved these changes

View reviewed changes

src/ComInprocTestbed/ComInprocTestbed.manifest

Comment on lines +11 to +21

+              			<!-- Windows Vista -->
+              			<!--<supportedOS Id="{e2011457-1546-43c5-a5fe-008deee3d3f0}" />-->
+              			<!-- Windows 7 -->
+              			<!--<supportedOS Id="{35138b9a-5d96-4fbd-8e2d-a2440225f93a}" />-->
+              			<!-- Windows 8 -->
+              			<!--<supportedOS Id="{4a2f28e3-53b9-4441-ba9c-d69d4a4a6e38}" />-->
+              			<!-- Windows 8.1 -->
+              			<!--<supportedOS Id="{1f676c76-80e1-4239-95bb-83d0f6d0da78}" />-->

Member

florelis Dec 12, 2025

nit: do we need to keep this part of the template?

src/ComInprocTestbed/ComInprocTestbed.vcxproj

Comment on lines +103 to +106

+                    <TreatWarningAsError Condition="'$(Configuration)|$(Platform)'=='Debug|ARM64'">true</TreatWarningAsError>
+                    <TreatWarningAsError Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">true</TreatWarningAsError>
+                    <LanguageStandard Condition="'$(Configuration)|$(Platform)'=='Debug|ARM64'">stdcpp17</LanguageStandard>
+                    <LanguageStandard Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">stdcpp17</LanguageStandard>

Member

florelis Dec 12, 2025

Suggested change

      
                  <TreatWarningAsError Condition="'$(Configuration)|$(Platform)'=='Debug|ARM64'">true</TreatWarningAsError>
          
                  <TreatWarningAsError Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">true</TreatWarningAsError>
          
                  <LanguageStandard Condition="'$(Configuration)|$(Platform)'=='Debug|ARM64'">stdcpp17</LanguageStandard>
          
                  <LanguageStandard Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">stdcpp17</LanguageStandard>
          
                  <TreatWarningAsError>true</TreatWarningAsError>
          
                  <LanguageStandard>stdcpp17</LanguageStandard>

src/ComInprocTestbed/ComInprocTestbed.vcxproj

Comment on lines +43 to +78

+                <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">
+                  <LinkIncremental>true</LinkIncremental>
+                  <OutDir>$(SolutionDir)$(Platform)\$(Configuration)\$(ProjectName)\</OutDir>
+                  <EmbedManifest>false</EmbedManifest>
+                  <CopyLocalProjectReference>true</CopyLocalProjectReference>
+                </PropertyGroup>
+                <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|ARM64'">
+                  <LinkIncremental>true</LinkIncremental>
+                  <OutDir>$(SolutionDir)$(Platform)\$(Configuration)\$(ProjectName)\</OutDir>
+                  <EmbedManifest>false</EmbedManifest>
+                  <CopyLocalProjectReference>true</CopyLocalProjectReference>
+                </PropertyGroup>
+                <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">
+                  <LinkIncremental>true</LinkIncremental>
+                  <OutDir>$(SolutionDir)x86\$(Configuration)\$(ProjectName)\</OutDir>
+                  <EmbedManifest>false</EmbedManifest>
+                  <CopyLocalProjectReference>true</CopyLocalProjectReference>
+                </PropertyGroup>
+                <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">
+                  <LinkIncremental>false</LinkIncremental>
+                  <OutDir>$(SolutionDir)x86\$(Configuration)\$(ProjectName)\</OutDir>
+                  <EmbedManifest>false</EmbedManifest>
+                  <CopyLocalProjectReference>true</CopyLocalProjectReference>
+                </PropertyGroup>
+                <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
+                  <LinkIncremental>false</LinkIncremental>
+                  <OutDir>$(SolutionDir)$(Platform)\$(Configuration)\$(ProjectName)\</OutDir>
+                  <EmbedManifest>false</EmbedManifest>
+                  <CopyLocalProjectReference>true</CopyLocalProjectReference>
+                </PropertyGroup>
+                <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|ARM64'">
+                  <LinkIncremental>false</LinkIncremental>
+                  <OutDir>$(SolutionDir)$(Platform)\$(Configuration)\$(ProjectName)\</OutDir>
+                  <EmbedManifest>false</EmbedManifest>
+                  <CopyLocalProjectReference>true</CopyLocalProjectReference>
+                </PropertyGroup>

Member

florelis Dec 12, 2025

Suggested change

      
              <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">
          
                <LinkIncremental>true</LinkIncremental>
          
                <OutDir>$(SolutionDir)$(Platform)\$(Configuration)\$(ProjectName)\</OutDir>
          
                <EmbedManifest>false</EmbedManifest>
          
                <CopyLocalProjectReference>true</CopyLocalProjectReference>
          
              </PropertyGroup>
          
              <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|ARM64'">
          
                <LinkIncremental>true</LinkIncremental>
          
                <OutDir>$(SolutionDir)$(Platform)\$(Configuration)\$(ProjectName)\</OutDir>
          
                <EmbedManifest>false</EmbedManifest>
          
                <CopyLocalProjectReference>true</CopyLocalProjectReference>
          
              </PropertyGroup>
          
              <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">
          
                <LinkIncremental>true</LinkIncremental>
          
                <OutDir>$(SolutionDir)x86\$(Configuration)\$(ProjectName)\</OutDir>
          
                <EmbedManifest>false</EmbedManifest>
          
                <CopyLocalProjectReference>true</CopyLocalProjectReference>
          
              </PropertyGroup>
          
              <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">
          
                <LinkIncremental>false</LinkIncremental>
          
                <OutDir>$(SolutionDir)x86\$(Configuration)\$(ProjectName)\</OutDir>
          
                <EmbedManifest>false</EmbedManifest>
          
                <CopyLocalProjectReference>true</CopyLocalProjectReference>
          
              </PropertyGroup>
          
              <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
          
                <LinkIncremental>false</LinkIncremental>
          
                <OutDir>$(SolutionDir)$(Platform)\$(Configuration)\$(ProjectName)\</OutDir>
          
                <EmbedManifest>false</EmbedManifest>
          
                <CopyLocalProjectReference>true</CopyLocalProjectReference>
          
              </PropertyGroup>
          
              <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|ARM64'">
          
                <LinkIncremental>false</LinkIncremental>
          
                <OutDir>$(SolutionDir)$(Platform)\$(Configuration)\$(ProjectName)\</OutDir>
          
                <EmbedManifest>false</EmbedManifest>
          
                <CopyLocalProjectReference>true</CopyLocalProjectReference>
          
              </PropertyGroup>
          
              <PropertyGroup>
          
                <OutDir>$(SolutionDir)$(Platform)\$(Configuration)\$(ProjectName)\</OutDir>
          
                <OutDir Condition="'$(Platform)'=='Win32'">$(SolutionDir)x86\$(Configuration)\$(ProjectName)\</OutDir>
          
                <EmbedManifest>false</EmbedManifest>
          
                <CopyLocalProjectReference>true</CopyLocalProjectReference>
          
              </PropertyGroup>
          
              <PropertyGroup Condition="'$(Configuration)'=='Debug'">
          
                <LinkIncremental>true</LinkIncremental>
          
              </PropertyGroup>
          
              <PropertyGroup Condition="'$(Configuration)'=='Release'">
          
                <LinkIncremental>false</LinkIncremental>
          
              </PropertyGroup>

src/ComInprocTestbed/ComInprocTestbed.vcxproj

Comment on lines +113 to +118

+                  <Manifest>
+                    <AdditionalManifestFiles Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">ComInprocTestbed.manifest</AdditionalManifestFiles>
+                  </Manifest>
+                  <Manifest>
+                    <AdditionalManifestFiles Condition="'$(Configuration)|$(Platform)'=='Debug|ARM64'">ComInprocTestbed.manifest</AdditionalManifestFiles>
+                  </Manifest>

Member

florelis Dec 12, 2025

Suggested change

      
                <Manifest>
          
                  <AdditionalManifestFiles Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">ComInprocTestbed.manifest</AdditionalManifestFiles>
          
                </Manifest>
          
                <Manifest>
          
                  <AdditionalManifestFiles Condition="'$(Configuration)|$(Platform)'=='Debug|ARM64'">ComInprocTestbed.manifest</AdditionalManifestFiles>
          
                </Manifest>
          
                <Manifest>
          
                  <AdditionalManifestFiles>ComInprocTestbed.manifest</AdditionalManifestFiles>
          
                </Manifest>

src/ComInprocTestbed/ComInprocTestbed.vcxproj

Comment on lines +120 to +129

+                <ItemDefinitionGroup Condition="'$(Platform)'=='Win32'">
+                  <ClCompile>
+                    <PreprocessorDefinitions>WIN32;%(PreprocessorDefinitions)</PreprocessorDefinitions>
+                    <TreatWarningAsError Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">true</TreatWarningAsError>
+                    <LanguageStandard Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">stdcpp17</LanguageStandard>
+                  </ClCompile>
+                  <Manifest>
+                    <AdditionalManifestFiles Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">ComInprocTestbed.manifest</AdditionalManifestFiles>
+                  </Manifest>
+                </ItemDefinitionGroup>

Member

florelis Dec 12, 2025

Suggested change

      
              <ItemDefinitionGroup Condition="'$(Platform)'=='Win32'">
          
                <ClCompile>
          
                  <PreprocessorDefinitions>WIN32;%(PreprocessorDefinitions)</PreprocessorDefinitions>
          
                  <TreatWarningAsError Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">true</TreatWarningAsError>
          
                  <LanguageStandard Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">stdcpp17</LanguageStandard>
          
                </ClCompile>
          
                <Manifest>
          
                  <AdditionalManifestFiles Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">ComInprocTestbed.manifest</AdditionalManifestFiles>
          
                </Manifest>
          
              </ItemDefinitionGroup>
          
              <ItemDefinitionGroup Condition="'$(Platform)'=='Win32'">
          
                <ClCompile>
          
                  <PreprocessorDefinitions>WIN32;%(PreprocessorDefinitions)</PreprocessorDefinitions>
          
                </ClCompile>
          
              </ItemDefinitionGroup>

src/ComInprocTestbed/ComInprocTestbed.vcxproj

Comment on lines +136 to +141

+                    <TreatWarningAsError Condition="'$(Configuration)|$(Platform)'=='Release|ARM64'">true</TreatWarningAsError>
+                    <TreatWarningAsError Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">true</TreatWarningAsError>
+                    <TreatWarningAsError Condition="'$(Configuration)|$(Platform)'=='Release|x64'">true</TreatWarningAsError>
+                    <LanguageStandard Condition="'$(Configuration)|$(Platform)'=='Release|ARM64'">stdcpp17</LanguageStandard>
+                    <LanguageStandard Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">stdcpp17</LanguageStandard>
+                    <LanguageStandard Condition="'$(Configuration)|$(Platform)'=='Release|x64'">stdcpp17</LanguageStandard>

Member

florelis Dec 12, 2025

Suggested change

      
                  <TreatWarningAsError Condition="'$(Configuration)|$(Platform)'=='Release|ARM64'">true</TreatWarningAsError>
          
                  <TreatWarningAsError Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">true</TreatWarningAsError>
          
                  <TreatWarningAsError Condition="'$(Configuration)|$(Platform)'=='Release|x64'">true</TreatWarningAsError>
          
                  <LanguageStandard Condition="'$(Configuration)|$(Platform)'=='Release|ARM64'">stdcpp17</LanguageStandard>
          
                  <LanguageStandard Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">stdcpp17</LanguageStandard>
          
                  <LanguageStandard Condition="'$(Configuration)|$(Platform)'=='Release|x64'">stdcpp17</LanguageStandard>
          
                  <TreatWarningAsError>true</TreatWarningAsError>
          
                  <LanguageStandard>stdcpp17</LanguageStandard>

src/ComInprocTestbed/ComInprocTestbed.vcxproj

Comment on lines +163 to +168

+                    <PrecompiledHeader Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">Create</PrecompiledHeader>
+                    <PrecompiledHeader Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">Create</PrecompiledHeader>
+                    <PrecompiledHeader Condition="'$(Configuration)|$(Platform)'=='Debug|ARM64'">Create</PrecompiledHeader>
+                    <PrecompiledHeader Condition="'$(Configuration)|$(Platform)'=='Release|ARM64'">Create</PrecompiledHeader>
+                    <PrecompiledHeader Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">Create</PrecompiledHeader>
+                    <PrecompiledHeader Condition="'$(Configuration)|$(Platform)'=='Release|x64'">Create</PrecompiledHeader>

Member

florelis Dec 12, 2025

Suggested change

      
                  <PrecompiledHeader Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">Create</PrecompiledHeader>
          
                  <PrecompiledHeader Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">Create</PrecompiledHeader>
          
                  <PrecompiledHeader Condition="'$(Configuration)|$(Platform)'=='Debug|ARM64'">Create</PrecompiledHeader>
          
                  <PrecompiledHeader Condition="'$(Configuration)|$(Platform)'=='Release|ARM64'">Create</PrecompiledHeader>
          
                  <PrecompiledHeader Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">Create</PrecompiledHeader>
          
                  <PrecompiledHeader Condition="'$(Configuration)|$(Platform)'=='Release|x64'">Create</PrecompiledHeader>
          
                  <PrecompiledHeader>Create</PrecompiledHeader>

src/ComInprocTestbed/ComInprocTestbed.vcxproj

Comment on lines +149 to +157

+                  <Manifest>
+                    <AdditionalManifestFiles Condition="'$(Configuration)|$(Platform)'=='Release|ARM64'">ComInprocTestbed.manifest</AdditionalManifestFiles>
+                  </Manifest>
+                  <Manifest>
+                    <AdditionalManifestFiles Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">ComInprocTestbed.manifest</AdditionalManifestFiles>
+                  </Manifest>
+                  <Manifest>
+                    <AdditionalManifestFiles Condition="'$(Configuration)|$(Platform)'=='Release|x64'">ComInprocTestbed.manifest</AdditionalManifestFiles>
+                  </Manifest>

Member

florelis Dec 12, 2025

Suggested change

      
                <Manifest>
          
                  <AdditionalManifestFiles Condition="'$(Configuration)|$(Platform)'=='Release|ARM64'">ComInprocTestbed.manifest</AdditionalManifestFiles>
          
                </Manifest>
          
                <Manifest>
          
                  <AdditionalManifestFiles Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">ComInprocTestbed.manifest</AdditionalManifestFiles>
          
                </Manifest>
          
                <Manifest>
          
                  <AdditionalManifestFiles Condition="'$(Configuration)|$(Platform)'=='Release|x64'">ComInprocTestbed.manifest</AdditionalManifestFiles>
          
                </Manifest>
          
                <Manifest>
          
                  <AdditionalManifestFiles>ComInprocTestbed.manifest</AdditionalManifestFiles>
          
                </Manifest>

src/AppInstallerCLIE2ETests/InprocTestbedTests.cs

Comment on lines +77 to +78

		string assemblyLocation = Assembly.GetExecutingAssembly().Location;
		this.InprocTestbedPath = Path.Join(Path.GetDirectoryName(assemblyLocation), "..\\ComInprocTestbed\\ComInprocTestbed.exe");

Member

florelis Dec 12, 2025

Isn't there something like a TestContext.TestDirectory?

src/ComInprocTestbed/Tests.cpp

		@@ -0,0 +1,602 @@
		// Copyright (c) Microsoft Corporation.

Member

florelis Dec 12, 2025

(I'll admit that I didn't read this file very closely...)

JohnMcPMS merged commit 920c411 into microsoft:master

9 checks passed

JohnMcPMS deleted the inproc-testbed branch

December 15, 2025 18:08

Fulgen301 mentioned this pull request

Crash during process exit due to TerminationSignalHandler::Instance being created and trying to launch a thread during process exit #5870

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet